Merge pull request #11019 from nextcloud/bugfix/noid/parameter-out-of-range-middleware

fix(API): Add ParameterOutOfRange middleware

Author: nickvergessen

lib/AppInfo/Application.php

@@ -103,6 +103,7 @@
 use OCA\Talk\Maps\MapsPluginLoader;
 use OCA\Talk\Middleware\CanUseTalkMiddleware;
 use OCA\Talk\Middleware\InjectionMiddleware;
+use OCA\Talk\Middleware\ParameterOutOfRangeMiddleware;
 use OCA\Talk\Notification\Listener as NotificationListener;
 use OCA\Talk\Notification\Notifier;
 use OCA\Talk\OCP\TalkBackend;
@@ -165,6 +166,7 @@ public function __construct(array $urlParams = []) {
 	public function register(IRegistrationContext $context): void {
 		$context->registerMiddleWare(CanUseTalkMiddleware::class);
 		$context->registerMiddleWare(InjectionMiddleware::class);
+		$context->registerMiddleWare(ParameterOutOfRangeMiddleware::class);
 		$context->registerCapability(Capabilities::class);
 
 		// Listeners to load the UI and integrate it into other apps

lib/Middleware/ParameterOutOfRangeMiddleware.php

@@ -0,0 +1,50 @@
+<?php
+
+declare(strict_types=1);
+/**
+ * @copyright Copyright (c) 2023 Joas Schilling <[email protected]>
+ *
+ * @author Joas Schilling <[email protected]>
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+namespace OCA\Talk\Middleware;
+
+use OCP\AppFramework\Controller;
+use OCP\AppFramework\Http;
+use OCP\AppFramework\Http\DataResponse;
+use OCP\AppFramework\Http\ParameterOutOfRangeException;
+use OCP\AppFramework\Http\Response;
+use OCP\AppFramework\Middleware;
+use OCP\AppFramework\OCSController;
+
+class ParameterOutOfRangeMiddleware extends Middleware {
+	/**
+	 * @throws \Exception
+	 */
+	public function afterException(Controller $controller, string $methodName, \Exception $exception): Response {
+		if ($exception instanceof ParameterOutOfRangeException
+			&& $controller instanceof OCSController) {
+			return new DataResponse([
+				'error' => $exception->getParameterName(),
+			], Http::STATUS_BAD_REQUEST);
+		}
+
+		throw $exception;
+	}
+}