Skip to content

Commit 28c757f

Browse files
authored
Merge pull request #10356 from nextcloud/fix/left-sidebar-wrong-user-status-on-scrolling
fix(LeftSidebar): wrong user status after scrolling
2 parents 2161f97 + ed07976 commit 28c757f

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

src/components/ConversationIcon.vue

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,11 @@
3535
:height="size"
3636
:alt="item.displayName"
3737
class="avatar icon">
38+
<!-- NcAvatar doesn't fully support props update and works only for 1 user -->
39+
<!-- Using key on NcAvatar forces NcAvatar re-mount and solve the problem, could not really optimal -->
40+
<!-- TODO: Check if props update support in NcAvatar is more performant -->
3841
<NcAvatar v-else
42+
:key="item.token"
3943
:size="size"
4044
:user="item.name"
4145
:disable-menu="disableMenu"
@@ -48,14 +52,12 @@
4852
class="conversation-icon__avatar" />
4953
<div v-if="showCall"
5054
class="overlap-icon">
51-
<VideoIcon :size="20"
52-
:fill-color="'#E9322D'" />
55+
<VideoIcon :size="20" :fill-color="'#E9322D'" />
5356
<span class="hidden-visually">{{ t('spreed', 'Call in progress') }}</span>
5457
</div>
5558
<div v-else-if="showFavorite"
5659
class="overlap-icon">
57-
<Star :size="20"
58-
:fill-color="'#FFCC00'" />
60+
<Star :size="20" :fill-color="'#FFCC00'" />
5961
<span class="hidden-visually">{{ t('spreed', 'Favorite') }}</span>
6062
</div>
6163
</div>

0 commit comments

Comments
 (0)