From 61b55c88dae27279ffe825a2ef69024af78f4874 Mon Sep 17 00:00:00 2001 From: Anna Larch Date: Mon, 15 Aug 2022 20:27:02 +0200 Subject: [PATCH] performance optimisation for carddav backend blob data read Signed-off-by: Anna Larch --- apps/dav/lib/CardDAV/CardDavBackend.php | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/apps/dav/lib/CardDAV/CardDavBackend.php b/apps/dav/lib/CardDAV/CardDavBackend.php index a9ca2eb30a3c9..6b60d6701d47a 100644 --- a/apps/dav/lib/CardDAV/CardDavBackend.php +++ b/apps/dav/lib/CardDAV/CardDavBackend.php @@ -933,6 +933,12 @@ private function readBlob($cardData, &$modified = false) { $cardData = stream_get_contents($cardData); } + // Micro optimisation + // don't loop through + if (strpos($cardData, 'PHOTO:data:') === 0) { + return $cardData; + } + $cardDataArray = explode("\r\n", $cardData); $cardDataFiltered = []; @@ -956,7 +962,6 @@ private function readBlob($cardData, &$modified = false) { $cardDataFiltered[] = $line; } - return implode("\r\n", $cardDataFiltered); }