Skip to content

Commit f5b6ef9

Browse files
committed
fixup! More small improvements (e.g. dashboard, user status dialog)
1 parent 920a56c commit f5b6ef9

16 files changed

Lines changed: 30 additions & 36 deletions

apps/files/js/filelist.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1686,7 +1686,9 @@
16861686
td.append(
16871687
'<input id="select-' + this.id + '-' + fileData.id +
16881688
'" type="checkbox" class="selectCheckBox checkbox"/><label for="select-' + this.id + '-' + fileData.id + '">' +
1689-
'<span class="hidden-visually">' + t('files', 'Select') + '</span>' +
1689+
'<span class="hidden-visually">' + (fileData.type === 'dir' ?
1690+
t('files', 'Select directory "{dirName}"', {dirName: name}) :
1691+
t('files', 'Select file "{fileName}"', {fileName: name})) + '</span>' +
16901692
'</label>'
16911693
);
16921694

apps/settings/css/settings.scss

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -554,6 +554,9 @@ table.nostyle {
554554
.social-button {
555555
padding-left: 0 !important;
556556
margin-left: -10px;
557+
a {
558+
display: inline-block;
559+
}
557560

558561
img {
559562
padding: 10px;

core/css/apps.scss

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -160,12 +160,9 @@ kbd {
160160
}
161161
}
162162
a:focus-visible {
163-
border: 2px solid var(--color-primary);
164163
border-radius: var(--border-radius);
164+
box-shadow: var(--color-primary) inset 0 0 0 2px;
165165
outline: none;
166-
background-position: 12px center;
167-
line-height: 40px;
168-
padding: 0 10px 0 12px;
169166
}
170167
&.active,
171168
a:active,

core/css/header.scss

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@
2121
-moz-user-select: none;
2222
-ms-user-select: none;
2323
a:focus-visible, button:focus-visible, div[role="button"]:focus-visible {
24-
border: 2px solid var(--color-primary-text);
24+
box-shadow: inset 0 0 0 2px var(--color-primary-text);
2525
border-radius: var(--border-radius);
26-
margin: 0;
26+
outline: none;
2727
}
2828
}
2929

@@ -150,10 +150,8 @@
150150
background-color: var(--color-primary-light);
151151
}
152152
&:focus-visible {
153-
padding: 8px 10px;
154-
margin: 2px;
155-
width: calc(100% - 4px);
156-
height: $header-menu-entry-height - 4px !important;
153+
box-shadow: inset 0 0 0 2px var(--color-primary);
154+
outline: none;
157155
}
158156
span {
159157
display: inline-block;
@@ -254,8 +252,6 @@
254252

255253
&:focus-visible {
256254
outline: none;
257-
margin: 0;
258-
margin-top: 1px;
259255
}
260256
}
261257
}
@@ -469,9 +465,6 @@ nav[role='navigation'] {
469465
letter-spacing: -0.5px;
470466
font-size: 12px;
471467
margin: 2px;
472-
&:focus-visible {
473-
height: 43px;
474-
}
475468
}
476469

477470
/* focused app visual feedback */

core/css/inputs.scss

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,16 +70,16 @@ div[contenteditable=true],
7070
background-color: var(--color-main-background);
7171
color: var(--color-text-light);
7272
}
73+
&:focus-visible {
74+
box-shadow: 0 0 0 2px var(--color-primary);
75+
}
7376
}
7477
&:disabled {
7578
background-color: var(--color-background-dark);
7679
color: var(--color-text-maxcontrast);
7780
cursor: default;
7881
opacity: 0.5;
7982
}
80-
&:focus-visible {
81-
border-width: 2px;
82-
}
8383
&:required {
8484
box-shadow: none;
8585
}

core/src/components/HeaderMenu.vue

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -188,9 +188,8 @@ export default {
188188
opacity: 1;
189189
}
190190
191-
&__trigger:focus-active {
191+
&__trigger:focus-visible {
192192
outline: none;
193-
margin-top: 1px !important;
194193
}
195194
196195
&__wrapper {

dist/core-common.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/core-common.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/core-main.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/core-main.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)