fix: Only list remnants as disabled if option is enabled

come-nc · come-nc · commit e14620cb15f6 · 2024-06-06T16:48:27.000+02:00
Signed-off-by: Côme Chilliet &lt;come.chilliet@nextcloud.com&gt;
diff --git a/apps/user_ldap/lib/User_Proxy.php b/apps/user_ldap/lib/User_Proxy.php
@@ -440,6 +440,9 @@ public function setUserEnabled(string $uid, bool $enabled, callable $queryDataba
 	}
 
 	public function getDisabledUserList(?int $limit = null, int $offset = 0, string $search = ''): array {
+		if ((int)$this->getAccess(array_key_first($this->backends) ?? '')->connection->markRemnantsAsDisabled !== 1) {
+			return [];
+		}
 		$disabledUsers = $this->deletedUsersIndex->getUsers();
 		if ($search !== '') {
 			$disabledUsers = array_filter(

Original file line number	Diff line number	Diff line change
`@@ -440,6 +440,9 @@ public function setUserEnabled(string $uid, bool $enabled, callable $queryDataba`
`440`	`440`	`}`
`441`	`441`
`442`	`442`	`public function getDisabledUserList(?int $limit = null, int $offset = 0, string $search = ''): array {`
	`443`	`+ if ((int)$this->getAccess(array_key_first($this->backends) ?? '')->connection->markRemnantsAsDisabled !== 1) {`
	`444`	`+ return [];`
	`445`	`+ }`
`443`	`446`	`$disabledUsers = $this->deletedUsersIndex->getUsers();`
`444`	`447`	`if ($search !== '') {`
`445`	`448`	`$disabledUsers = array_filter(`