Fix primary and debounce to avoid infinite loop

Signed-off-by: John Molakvoæ <[email protected]>

Author: skjnldsv

apps/theming/lib/Themes/DefaultTheme.php

@@ -67,11 +67,12 @@ public function __construct(Util $util,
 		$this->l = $l;
 
 		$this->defaultPrimaryColor = $this->themingDefaults->getDefaultColorPrimary();
+		$this->primaryColor = $this->themingDefaults->getColorPrimary();
 
-		// Override default codefaultPrimaryColorlor if set to improve accessibility
-		$this->primaryColor = $this->defaultPrimaryColor === BackgroundService::DEFAULT_COLOR
-			? BackgroundService::DEFAULT_ACCESSIBLE_COLOR
-			: $this->themingDefaults->getColorPrimary();
+		// Override default defaultPrimaryColor if set to improve accessibility
+		if ($this->primaryColor === BackgroundService::DEFAULT_COLOR) {
+			$this->primaryColor = BackgroundService::DEFAULT_ACCESSIBLE_COLOR;
+		}
 	}
 
 	public function getId(): string {

apps/theming/lib/ThemingDefaults.php

@@ -226,7 +226,7 @@ public function getColorPrimary() {
 		// user-defined primary color
 		$themingBackground = '';
 		if (!empty($user)) {
-			$themingBackground = $this->config->getUserValue($user->getUID(), Application::APP_ID, 'background', 'default');
+			$themingBackground = $this->config->getUserValue($user->getUID(), Application::APP_ID, 'background', '');
 
 			// if the user-selected background is a background reference
 			if (!preg_match('/^\#([0-9a-f]{3}|[0-9a-f]{6})$/i', $themingBackground)) {

apps/theming/src/components/BackgroundSettings.vue

@@ -32,17 +32,6 @@
 			@click="pickFile">
 			{{ t('theming', 'Pick from Files') }}
 		</button>
-		<NcColorPicker v-model="Theming.color" @input="pickColor">
-			<button class="background color"
-				:class="{ active: background === Theming.color}"
-				tabindex="0"
-				:data-color="Theming.color"
-				:data-color-bright="invertTextColor(Theming.color)"
-				:style="{ backgroundColor: Theming.color, color: invertTextColor(Theming.color) ? '#000000' : '#ffffff'}"
-				@click="pickColor">
-				{{ t('theming', 'Custom color') }}
-			</button>
-		</NcColorPicker>
 
 		<!-- Default background -->
 		<button class="background default"
@@ -52,14 +41,26 @@
 			{{ t('theming', 'Default image') }}
 		</button>
 
+		<!-- Custom color picker -->
+		<NcColorPicker v-model="Theming.color" @input="debouncePickColor">
+			<button class="background color"
+				:class="{ active: background === Theming.color}"
+				tabindex="0"
+				:data-color="Theming.color"
+				:data-color-bright="invertTextColor(Theming.color)"
+				:style="{ backgroundColor: Theming.color, color: invertTextColor(Theming.color) ? '#000000' : '#ffffff'}">
+				{{ t('theming', 'Custom color') }}
+			</button>
+		</NcColorPicker>
+
 		<!-- Default admin primary color -->
 		<button class="background color"
 			:class="{ active: background === Theming.defaultColor }"
 			tabindex="0"
 			:data-color="Theming.defaultColor"
 			:data-color-bright="invertTextColor(Theming.defaultColor)"
 			:style="{ color: invertTextColor(Theming.defaultColor) ? '#000000' : '#ffffff'}"
-			@click="pickColor">
+			@click="debouncePickColor">
 			{{ t('theming', 'Plain background') }}
 		</button>
 
@@ -77,13 +78,14 @@
 </template>
 
 <script>
-import axios from '@nextcloud/axios'
-import Tooltip from '@nextcloud/vue/dist/Directives/Tooltip'
-import NcColorPicker from '@nextcloud/vue/dist/Components/NcColorPicker'
 import { generateUrl } from '@nextcloud/router'
-import { loadState } from '@nextcloud/initial-state'
 import { getBackgroundUrl } from '../helpers/getBackgroundUrl.js'
+import { loadState } from '@nextcloud/initial-state'
 import { prefixWithBaseUrl } from '../helpers/prefixWithBaseUrl.js'
+import axios from '@nextcloud/axios'
+import debounce from 'debounce'
+import NcColorPicker from '@nextcloud/vue/dist/Components/NcColorPicker'
+import Tooltip from '@nextcloud/vue/dist/Directives/Tooltip'
 
 const shippedBackgroundList = loadState('theming', 'shippedBackgrounds')
 
@@ -179,6 +181,9 @@ export default {
 			const result = await axios.post(generateUrl('/apps/theming/background/custom'), { value: path })
 			this.update(result.data)
 		},
+		debouncePickColor: debounce(function() {
+			this.pickColor(...arguments)
+		}, 200),
 		async pickColor(event) {
 			this.loading = 'color'
 			const color = event?.target?.dataset?.color || this.Theming?.color || '#0082c9'

apps/theming/tests/ThemingDefaultsTest.php

@@ -468,7 +468,7 @@ public function testGetColorPrimaryWithCustomBackground() {
 		$this->config
 			->expects($this->once())
 			->method('getUserValue')
-			->with('user', 'theming', 'background', 'default')
+			->with('user', 'theming', 'background', '')
 			->willReturn(array_keys(BackgroundService::SHIPPED_BACKGROUNDS)[$backgroundIndex]);
 
 		$this->assertEquals($background['primary_color'], $this->template->getColorPrimary());
@@ -486,7 +486,7 @@ public function testGetColorPrimaryWithCustomBackgroundColor() {
 		$this->config
 			->expects($this->once())
 			->method('getUserValue')
-			->with('user', 'theming', 'background', 'default')
+			->with('user', 'theming', 'background', '')
 			->willReturn('#fff');
 
 		$this->assertEquals('#fff', $this->template->getColorPrimary());
@@ -504,7 +504,7 @@ public function testGetColorPrimaryWithInvalidCustomBackgroundColor() {
 		$this->config
 			->expects($this->once())
 			->method('getUserValue')
-			->with('user', 'theming', 'background', 'default')
+			->with('user', 'theming', 'background', '')
 			->willReturn('nextcloud');
 
 		$this->assertEquals($this->template->getDefaultColorPrimary(), $this->template->getColorPrimary());