fix(profile): allow to reset phone number

Signed-off-by: Ferdinand Thiessen <[email protected]>

Author: susnux

apps/settings/src/components/PersonalInfo/PhoneSection.vue

@@ -56,6 +56,10 @@ export default {
 
 	methods: {
 		onValidate(value) {
+			if (value === '') {
+				return true
+			}
+
 			if (defaultPhoneRegion) {
 				return isValidPhoneNumber(value, defaultPhoneRegion)
 			}

cypress/e2e/settings/personal-info.cy.ts

@@ -337,6 +337,40 @@ describe('Settings: Change personal information', { testIsolation: true }, () =>
 		cy.get('a[href="tel:+498972101099701"]').should('be.visible')
 	})
 
+	it('Can set phone number with phone region', () => {
+		cy.contains('label', 'Phone number').scrollIntoView()
+		inputForLabel('Phone number').type('{selectAll}0 40 428990')
+		inputForLabel('Phone number').should('have.attr', 'class').and('contain', '--error')
+
+		cy.runOccCommand('config:system:set default_phone_region --value DE')
+		cy.reload()
+
+		cy.contains('label', 'Phone number').scrollIntoView()
+		inputForLabel('Phone number').type('{selectAll}0 40 428990')
+		handlePasswordConfirmation(user.password)
+
+		cy.wait('@submitSetting')
+		cy.reload()
+		inputForLabel('Phone number').should('have.value', '+4940428990')
+	})
+
+	it('Can reset phone number', () => {
+		cy.contains('label', 'Phone number').scrollIntoView()
+		inputForLabel('Phone number').type('{selectAll}+49 40 428990')
+		handlePasswordConfirmation(user.password)
+
+		cy.wait('@submitSetting')
+		cy.reload()
+		inputForLabel('Phone number').should('have.value', '+4940428990')
+
+		inputForLabel('Phone number').clear()
+		handlePasswordConfirmation(user.password)
+
+		cy.wait('@submitSetting')
+		cy.reload()
+		inputForLabel('Phone number').should('have.value', '')
+	})
+
 	it('Can set Website and change its visibility', () => {
 		cy.contains('label', 'Website').scrollIntoView()
 		// Check invalid input