Merge pull request #22657 from nextcloud/bugfix/noid/quota-trash-creation

Check if quota should be applied to path when creating directories

Author: MorrisJobke

lib/private/Files/Storage/Wrapper/Quota.php

@@ -161,7 +161,7 @@ public function fopen($path, $mode) {
 			$free = $this->free_space($path);
 			if ($source && $free >= 0 && $mode !== 'r' && $mode !== 'rb') {
 				// only apply quota for files, not metadata, trash or others
-				if (strpos(ltrim($path, '/'), 'files/') === 0) {
+				if ($this->shouldApplyQuota($path)) {
 					return \OC\Files\Stream\Quota::wrap($source, $free);
 				}
 			}
@@ -182,6 +182,13 @@ private function isPartFile($path) {
 		return ($extension === 'part');
 	}
 
+	/**
+	 * Only apply quota for files, not metadata, trash or others
+	 */
+	private function shouldApplyQuota(string $path): bool {
+		return strpos(ltrim($path, '/'), 'files/') === 0;
+	}
+
 	/**
 	 * @param IStorage $sourceStorage
 	 * @param string $sourceInternalPath
@@ -214,7 +221,7 @@ public function moveFromStorage(IStorage $sourceStorage, $sourceInternalPath, $t
 
 	public function mkdir($path) {
 		$free = $this->free_space($path);
-		if ($free === 0.0) {
+		if ($this->shouldApplyQuota($path) && $free === 0.0) {
 			return false;
 		}
 

tests/lib/Files/Storage/Wrapper/QuotaTest.php

@@ -211,7 +211,16 @@ public function testInstanceOfStorageWrapper() {
 
 	public function testNoMkdirQuotaZero() {
 		$instance = $this->getLimitedStorage(0.0);
-		$this->assertFalse($instance->mkdir('foobar'));
+		$this->assertFalse($instance->mkdir('files'));
+		$this->assertFalse($instance->mkdir('files/foobar'));
+	}
+
+	public function testMkdirQuotaZeroTrashbin() {
+		$instance = $this->getLimitedStorage(0.0);
+		$this->assertTrue($instance->mkdir('files_trashbin'));
+		$this->assertTrue($instance->mkdir('files_trashbin/files'));
+		$this->assertTrue($instance->mkdir('files_versions'));
+		$this->assertTrue($instance->mkdir('cache'));
 	}
 
 	public function testNoTouchQuotaZero() {