fixup! feat(cardav): support result truncation for addressbook federation

Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>

Author: hamza221

apps/dav/lib/CardDAV/CardDavBackend.php

@@ -852,7 +852,7 @@ public function deleteCard($addressBookId, $cardUri) {
 	 * @return array
 	 */
 	public function getChangesForAddressBook($addressBookId, $syncToken, $syncLevel, $limit = null) {
-		$maxLimit = $this->config->getSystemValueInt('carddav_sync_request_truncation', 50000);
+		$maxLimit = $this->config->getSystemValueInt('carddav_sync_request_truncation', 2500);
 		$limit = ($limit === null) ? $maxLimit : min($limit, $maxLimit);
 		// Current synctoken
 		return $this->atomic(function () use ($addressBookId, $syncToken, $syncLevel, $limit) {

apps/dav/tests/unit/CardDAV/SyncServiceTest.php

@@ -108,7 +108,7 @@ public function testEmptySync(): void {
 			'1',
 			'principals/system/system',
 			[]
-		);
+		)['token'];
 
 		$this->assertEquals('http://sabre.io/ns/sync/1', $token);
 	}
@@ -179,7 +179,7 @@ public function testSyncWithNewElement(): void {
 			'1',
 			'principals/system/system',
 			[]
-		);
+		)['token'];
 
 		$this->assertEquals('http://sabre.io/ns/sync/2', $token);
 	}
@@ -250,7 +250,7 @@ public function testSyncWithUpdatedElement(): void {
 			'1',
 			'principals/system/system',
 			[]
-		);
+		)['token'];
 
 		$this->assertEquals('http://sabre.io/ns/sync/3', $token);
 	}
@@ -291,7 +291,7 @@ public function testSyncWithDeletedElement(): void {
 			'1',
 			'principals/system/system',
 			[]
-		);
+		)['token'];
 
 		$this->assertEquals('http://sabre.io/ns/sync/4', $token);
 	}
@@ -422,7 +422,7 @@ public function testDeleteAddressbookWhenAccessRevoked(): void {
 			'1',
 			'principals/system/system',
 			[]
-		);
+		)['token'];
 	}
 
 	#[\PHPUnit\Framework\Attributes\DataProvider('providerUseAbsoluteUriReport')]
@@ -462,7 +462,7 @@ public function testUseAbsoluteUriReport(string $host, string $expected): void {
 			'1',
 			'principals/system/system',
 			[]
-		);
+		)['token'];
 	}
 
 	public static function providerUseAbsoluteUriReport(): array {

config/config.sample.php

@@ -357,7 +357,7 @@
 /**
  * The limit applied to the synchronization report request, e.g. federated system address books (as run by `occ federation:sync-addressbooks`).
  */
-'carddav_sync_request_truncation' => 50000,
+'carddav_sync_request_truncation' => 2500,
 
 /**
  * `true` enables a relaxed session timeout, where the session timeout would no longer be