Skip to content

Commit 70a6eee

Browse files
committed
fix: log fopen calls when stream isn't available
Signed-off-by: Anna Larch <[email protected]>
1 parent ec4ae84 commit 70a6eee

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

lib/private/Streamer.php

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
use OCP\Files\NotPermittedException;
3737
use OCP\IRequest;
3838
use ownCloud\TarStreamer\TarStreamer;
39+
use Psr\Log\LoggerInterface;
3940
use ZipStreamer\ZipStreamer;
4041

4142
class Streamer {
@@ -122,10 +123,16 @@ public function addDirRecursive(string $dir, string $internalDir = ''): void {
122123
$dirNode = $userFolder->get($dir);
123124
$files = $dirNode->getDirectoryListing();
124125

126+
/** @var LoggerInterface $logger */
127+
$logger = \OC::$server->query(LoggerInterface::class);
125128
foreach ($files as $file) {
126129
if ($file instanceof File) {
127130
try {
128131
$fh = $file->fopen('r');
132+
if ($fh === false) {
133+
$logger->error('Unable to open file for stream: ' . print_r($file, true));
134+
continue;
135+
}
129136
} catch (NotPermittedException $e) {
130137
continue;
131138
}

0 commit comments

Comments
 (0)