Refactor "substr" calls to improve code readability

shdehnavi · shdehnavi · commit 621dc795b0cd · 2023-07-07T04:56:11.000+03:30
Signed-off-by: Hamid Dehnavi &lt;hamid.dev.pro@gmail.com&gt;
diff --git a/lib/public/AppFramework/AuthPublicShareController.php b/lib/public/AppFramework/AuthPublicShareController.php
@@ -216,7 +216,7 @@ final public function getAuthenticationRedirect(string $redirect): RedirectRespo
 	private function getRoute(string $function): string {
 		$app = strtolower($this->appName);
 		$class = (new \ReflectionClass($this))->getShortName();
-		if (substr($class, -10) === 'Controller') {
+		if (str_ends_with($class, 'Controller')) {
 			$class = substr($class, 0, -10);
 		}
 		return $app .'.'. $class .'.'. $function;

Original file line number	Diff line number	Diff line change
`@@ -216,7 +216,7 @@ final public function getAuthenticationRedirect(string $redirect): RedirectRespo`
`216`	`216`	`private function getRoute(string $function): string {`
`217`	`217`	`$app = strtolower($this->appName);`
`218`	`218`	`$class = (new \ReflectionClass($this))->getShortName();`
`219`		`- if (substr($class, -10) === 'Controller') {`
	`219`	`+ if (str_ends_with($class, 'Controller')) {`
`220`	`220`	`$class = substr($class, 0, -10);`
`221`	`221`	`}`
`222`	`222`	`return $app .'.'. $class .'.'. $function;`