fix(appconfig): format app values

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>

Author: ArtificialOwl

lib/private/AppConfig.php

@@ -271,7 +271,8 @@ public function searchValues(string $key, bool $lazy = false): array {
 
 		foreach (array_keys($cache) as $app) {
 			if (isset($cache[$app][$key])) {
-				$values[$app] = $cache[$app][$key];
+				$appCache = $this->formatAppValues((string)$app, $cache[$app], $lazy);
+				$values[$app] = $appCache[$key];
 			}
 		}
 
@@ -510,9 +511,9 @@ private function getTypedValue(
 	 * @see VALUE_BOOL
 	 * @see VALUE_ARRAY
 	 */
-	public function getValueType(string $app, string $key): int {
+	public function getValueType(string $app, string $key, ?bool $lazy = null): int {
 		$this->assertParams($app, $key);
-		$this->loadConfigAll();
+		$this->loadConfig($lazy);
 
 		if (!isset($this->valueTypes[$app][$key])) {
 			throw new AppConfigUnknownKeyException('unknown config key');
@@ -1393,9 +1394,15 @@ public function getFilteredValues($app) {
 	 *
 	 * @return array
 	 */
-	private function formatAppValues(string $app, array $values): array {
+	private function formatAppValues(string $app, array $values, ?bool $lazy = null): array {
 		foreach($values as $key => $value) {
-			switch ($this->getValueType($app, $key)) {
+			try {
+				$type = $this->getValueType($app, $key, $lazy);
+			} catch (AppConfigUnknownKeyException $e) {
+				continue; // ignorable
+			}
+
+			switch ($type) {
 				case self::VALUE_INT:
 					$values[$key] = (int)$value;
 					break;

lib/public/IAppConfig.php

@@ -261,9 +261,11 @@ public function getValueArray(string $app, string $key, array $default = [], boo
 	 * returns the type of config value
 	 *
 	 * **WARNING:** ignore lazy filtering, all config values are loaded from database
+	 *              unless lazy is set to false
 	 *
 	 * @param string $app id of the app
 	 * @param string $key config key
+	 * @param bool|null $lazy
 	 *
 	 * @return int
 	 * @throws AppConfigUnknownKeyException
@@ -274,7 +276,7 @@ public function getValueArray(string $app, string $key, array $default = [], boo
 	 * @see VALUE_BOOL
 	 * @see VALUE_ARRAY
 	 */
-	public function getValueType(string $app, string $key): int;
+	public function getValueType(string $app, string $key, ?bool $lazy = null): int;
 
 	/**
 	 * Store a config key and its value in database