Merge pull request #36316 from nextcloud/improve-fatal-logging

szaimen · web-flow · commit 3a9abb256ebb · 2023-05-23T23:02:18.000+02:00
Log to `error_log` in fatal case
diff --git a/lib/private/Log.php b/lib/private/Log.php
@@ -359,6 +359,7 @@ public function logData(string $message, array $data, array $context = []): void
 			$context['level'] = $level;
 		} catch (Throwable $e) {
 			// make sure we dont hard crash if logging fails
+			error_log('Error when trying to log exception: ' . $e->getMessage() . ' ' . $e->getTraceAsString());
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -359,6 +359,7 @@ public function logData(string $message, array $data, array $context = []): void`
`359`	`359`	`$context['level'] = $level;`
`360`	`360`	`} catch (Throwable $e) {`
`361`	`361`	`// make sure we dont hard crash if logging fails`
	`362`	`+ error_log('Error when trying to log exception: ' . $e->getMessage() . ' ' . $e->getTraceAsString());`
`362`	`363`	`}`
`363`	`364`	`}`
`364`	`365`