fix(SetupChecks): Add reasoning/clarity to outdated PHP check

joshtrichards · joshtrichards · commit 2aa4d1285df8 · 2024-05-11T10:37:14.000-04:00
Signed-off-by: Josh Richards &lt;josh.t.richards@gmail.com&gt;
diff --git a/apps/settings/lib/SetupChecks/PhpOutdated.php b/apps/settings/lib/SetupChecks/PhpOutdated.php
@@ -47,7 +47,7 @@ public function getName(): string {
 
 	public function run(): SetupResult {
 		if (PHP_VERSION_ID < 80200) {
-			return SetupResult::warning($this->l10n->t('You are currently running PHP %s. PHP 8.1 is now deprecated in Nextcloud 30. Nextcloud 31 may require at least PHP 8.2. Please upgrade to one of the officially supported PHP versions provided by the PHP Group as soon as possible.', [PHP_VERSION]), 'https://secure.php.net/supported-versions.php');
+			return SetupResult::warning($this->l10n->t('PHP %s detected. PHP >=8.2 and <= 8.3 is suggested for optimal performance, security, and stability with this version of Nextcloud. Additionally, the next major release of Nextcloud will likely require >= PHP 8.2.', [PHP_VERSION]), 'https://secure.php.net/supported-versions.php');
 		}
 		return SetupResult::success($this->l10n->t('You are currently running PHP %s.', [PHP_VERSION]));
 	}

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ public function getName(): string {`
`47`	`47`
`48`	`48`	`public function run(): SetupResult {`
`49`	`49`	`if (PHP_VERSION_ID < 80200) {`
`50`		`- return SetupResult::warning($this->l10n->t('You are currently running PHP %s. PHP 8.1 is now deprecated in Nextcloud 30. Nextcloud 31 may require at least PHP 8.2. Please upgrade to one of the officially supported PHP versions provided by the PHP Group as soon as possible.', [PHP_VERSION]), 'https://secure.php.net/supported-versions.php');`
	`50`	`+ return SetupResult::warning($this->l10n->t('PHP %s detected. PHP >=8.2 and <= 8.3 is suggested for optimal performance, security, and stability with this version of Nextcloud. Additionally, the next major release of Nextcloud will likely require >= PHP 8.2.', [PHP_VERSION]), 'https://secure.php.net/supported-versions.php');`
`51`	`51`	`}`
`52`	`52`	`return SetupResult::success($this->l10n->t('You are currently running PHP %s.', [PHP_VERSION]));`
`53`	`53`	`}`