Skip import of current calendar on error

Signed-off-by: Christopher Ng <[email protected]>

Author: Pytal

apps/dav/lib/UserMigration/CalendarMigrator.php

@@ -318,6 +318,9 @@ private function initCalendarObject(): VCalendar {
 		return $vCalendarObject;
 	}
 
+	/**
+	 * @throws InvalidCalendarException
+	 */
 	private function importCalendarObject(int $calendarId, VCalendar $vCalendarObject, OutputInterface $output): void {
 		try {
 			$this->calDavBackend->createCalendarObject(
@@ -330,11 +333,12 @@ private function importCalendarObject(int $calendarId, VCalendar $vCalendarObjec
 			// Rollback creation of calendar on error
 			$output->writeln('Error creating calendar object, rolling back creation of calendar…');
 			$this->calDavBackend->deleteCalendar($calendarId, true);
+			throw new InvalidCalendarException();
 		}
 	}
 
 	/**
-	 * @throws CalendarMigratorException
+	 * @throws InvalidCalendarException
 	 */
 	private function importCalendar(IUser $user, string $filename, string $initialCalendarUri, VCalendar $vCalendar, OutputInterface $output): void {
 		$principalUri = $this->getPrincipalUri($user);
@@ -446,15 +450,19 @@ public function import(IUser $user, IImportSource $importSource, OutputInterface
 			}
 			[$initialCalendarUri, $suffix] = $splitFilename;
 
-			$this->importCalendar(
-				$user,
-				$filename,
-				$initialCalendarUri,
-				$vCalendar,
-				$output,
-			);
-
-			$vCalendar->destroy();
+			try {
+				$this->importCalendar(
+					$user,
+					$filename,
+					$initialCalendarUri,
+					$vCalendar,
+					$output,
+				);
+			} catch (InvalidCalendarException $e) {
+				// Allow this exception to skip failed calendar import
+			} finally {
+				$vCalendar->destroy();
+			}
 		}
 	}
 }