Skip to content

Commit 25fa8c4

Browse files
authored
Merge pull request #44849 from nextcloud/fix/drop-old-dependencies
fix: Drop unmaintained and unused dependencies
2 parents 3ad4bbb + daa69c5 commit 25fa8c4

7 files changed

Lines changed: 18 additions & 37 deletions

File tree

apps/comments/src/views/Comments.vue

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
-->
2323

2424
<template>
25-
<div v-observe-visibility="onVisibilityChange"
25+
<div v-element-visibility="onVisibilityChange"
2626
class="comments"
2727
:class="{ 'icon-loading': isFirstLoading }">
2828
<!-- Editor -->
@@ -86,9 +86,7 @@
8686
<script>
8787
import { showError } from '@nextcloud/dialogs'
8888
import { translate as t } from '@nextcloud/l10n'
89-
import VTooltip from 'v-tooltip'
90-
import Vue from 'vue'
91-
import VueObserveVisibility from 'vue-observe-visibility'
89+
import { vElementVisibility } from '@vueuse/components'
9290
9391
import NcEmptyContent from '@nextcloud/vue/dist/Components/NcEmptyContent.js'
9492
import NcButton from '@nextcloud/vue/dist/Components/NcButton.js'
@@ -97,13 +95,10 @@ import MessageReplyTextIcon from 'vue-material-design-icons/MessageReplyText.vue
9795
import AlertCircleOutlineIcon from 'vue-material-design-icons/AlertCircleOutline.vue'
9896
9997
import Comment from '../components/Comment.vue'
100-
import { getComments, DEFAULT_LIMIT } from '../services/GetComments.ts'
98+
import CommentView from '../mixins/CommentView'
10199
import cancelableRequest from '../utils/cancelableRequest.js'
100+
import { getComments, DEFAULT_LIMIT } from '../services/GetComments.ts'
102101
import { markCommentsAsRead } from '../services/ReadComments.ts'
103-
import CommentView from '../mixins/CommentView'
104-
105-
Vue.use(VTooltip)
106-
Vue.use(VueObserveVisibility)
107102
108103
export default {
109104
name: 'Comments',
@@ -117,6 +112,10 @@ export default {
117112
AlertCircleOutlineIcon,
118113
},
119114
115+
directives: {
116+
vElementVisibility,
117+
},
118+
120119
mixins: [CommentView],
121120
122121
data() {

dist/comments-comments-app.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/comments-comments-app.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/core-common.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/core-common.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package-lock.json

Lines changed: 2 additions & 18 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,8 @@
6060
"@nextcloud/vue": "^8.11.2",
6161
"@simplewebauthn/browser": "^9.0.1",
6262
"@skjnldsv/sanitize-svg": "^1.0.2",
63-
"@vueuse/components": "^10.7.2",
64-
"@vueuse/core": "^10.7.2",
63+
"@vueuse/components": "^10.9.0",
64+
"@vueuse/core": "^10.9.0",
6565
"@vueuse/integrations": "^10.9.0",
6666
"backbone": "^1.4.1",
6767
"blueimp-md5": "^2.19.0",
@@ -109,8 +109,6 @@
109109
"vue-infinite-loading": "^2.4.5",
110110
"vue-localstorage": "^0.6.2",
111111
"vue-material-design-icons": "^5.0.0",
112-
"vue-multiselect": "^2.1.9",
113-
"vue-observe-visibility": "^1.0.0",
114112
"vue-router": "^3.6.5",
115113
"vuedraggable": "^2.24.3",
116114
"vuex": "^3.6.2",

0 commit comments

Comments
 (0)