[stable28] fix(UpdateNotifications): Handle numeric user ids

joshtrichards · joshtrichards · commit 1f8dc636812e · 2024-03-11T21:43:35.000-04:00
manual backport of #44093 to fix #44051 for <=v28 Signed-off-by: Josh <josh.t.richards@gmail.com>
diff --git a/apps/updatenotification/lib/Notification/BackgroundJob.php b/apps/updatenotification/lib/Notification/BackgroundJob.php
@@ -118,7 +118,7 @@ protected function sendErrorNotifications($numDays) {
 				->setSubject('connection_error', ['days' => $numDays]);
 
 			foreach ($this->getUsersToNotify() as $uid) {
-				$notification->setUser($uid);
+				$notification->setUser((string) $uid);
 				$this->notificationManager->notify($notification);
 			}
 		} catch (\InvalidArgumentException $e) {
@@ -186,7 +186,7 @@ protected function createNotifications($app, $version, $visibleVersion = '') {
 			}
 
 			foreach ($this->getUsersToNotify() as $uid) {
-				$notification->setUser($uid);
+				$notification->setUser((string) $uid);
 				$this->notificationManager->notify($notification);
 			}
 		} catch (\InvalidArgumentException $e) {

Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,7 @@ protected function sendErrorNotifications($numDays) {`
`118`	`118`	`->setSubject('connection_error', ['days' => $numDays]);`
`119`	`119`
`120`	`120`	`foreach ($this->getUsersToNotify() as $uid) {`
`121`		`- $notification->setUser($uid);`
	`121`	`+ $notification->setUser((string) $uid);`
`122`	`122`	`$this->notificationManager->notify($notification);`
`123`	`123`	`}`
`124`	`124`	`} catch (\InvalidArgumentException $e) {`
`@@ -186,7 +186,7 @@ protected function createNotifications($app, $version, $visibleVersion = '') {`
`186`	`186`	`}`
`187`	`187`
`188`	`188`	`foreach ($this->getUsersToNotify() as $uid) {`
`189`		`- $notification->setUser($uid);`
	`189`	`+ $notification->setUser((string) $uid);`
`190`	`190`	`$this->notificationManager->notify($notification);`
`191`	`191`	`}`
`192`	`192`	`} catch (\InvalidArgumentException $e) {`