Skip to content

Commit 17e6937

Browse files
nfebenextcloud-command
authored andcommitted
Fixed mixed translations in sharing details
Due to a typo in the app passed to the translation method, some strings translations don't work. This commit corrects the spelling `file_sharing` to `files_sharing` and hence resolves : #40801 Signed-off-by: fenn-cs <fenn25.fn@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
1 parent 4ae4ccc commit 17e6937

3 files changed

Lines changed: 22 additions & 19 deletions

File tree

apps/files_sharing/src/views/SharingDetailsTab.vue

Lines changed: 19 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -85,17 +85,17 @@
8585
<NcInputField v-if="isPublicShare"
8686
:value.sync="share.label"
8787
type="text"
88-
:label="t('file_sharing', 'Share label')" />
88+
:label="t('files_sharing', 'Share label')" />
8989
<template v-if="isPublicShare">
9090
<NcCheckboxRadioSwitch :checked.sync="isPasswordProtected" :disabled="isPasswordEnforced">
91-
{{ t('file_sharing', 'Set password') }}
91+
{{ t('files_sharing', 'Set password') }}
9292
</NcCheckboxRadioSwitch>
9393
<NcInputField v-if="isPasswordProtected"
9494
:type="hasUnsavedPassword ? 'text' : 'password'"
9595
:value="hasUnsavedPassword ? share.newPassword : '***************'"
9696
:error="passwordError"
9797
:required="isPasswordEnforced"
98-
:label="t('file_sharing', 'Password')"
98+
:label="t('files_sharing', 'Password')"
9999
@update:value="onPasswordChange" />
100100

101101
<!-- Migrate icons and remote -> icon="icon-info"-->
@@ -118,50 +118,53 @@
118118
:max="dateMaxEnforced"
119119
:hide-label="true"
120120
:disabled="isExpiryDateEnforced"
121-
:placeholder="t('file_sharing', 'Expiration date')"
121+
:placeholder="t('files_sharing', 'Expiration date')"
122122
type="date"
123123
@input="onExpirationChange" />
124124
<NcCheckboxRadioSwitch v-if="isPublicShare"
125125
:disabled="canChangeHideDownload"
126126
:checked.sync="share.hideDownload"
127127
@update:checked="queueUpdate('hideDownload')">
128-
{{ t('file_sharing', 'Hide download') }}
128+
{{ t('files_sharing', 'Hide download') }}
129129
</NcCheckboxRadioSwitch>
130130
<NcCheckboxRadioSwitch v-if="canTogglePasswordProtectedByTalkAvailable"
131131
:checked.sync="isPasswordProtectedByTalk"
132132
@update:checked="onPasswordProtectedByTalkChange">
133-
{{ t('file_sharing', 'Video verification') }}
133+
{{ t('files_sharing', 'Video verification') }}
134+
</NcCheckboxRadioSwitch>
135+
<NcCheckboxRadioSwitch v-if="!isPublicShare" :disabled="!canSetDownload" :checked.sync="canDownload">
136+
{{ t('files_sharing', 'Allow download') }}
134137
</NcCheckboxRadioSwitch>
135138
<NcCheckboxRadioSwitch v-if="!isPublicShare" :disabled="!canSetDownload" :checked.sync="canDownload">
136139
{{ t('file_sharing', 'Allow download') }}
137140
</NcCheckboxRadioSwitch>
138141
<NcCheckboxRadioSwitch :checked.sync="writeNoteToRecipientIsChecked">
139-
{{ t('file_sharing', 'Note to recipient') }}
142+
{{ t('files_sharing', 'Note to recipient') }}
140143
</NcCheckboxRadioSwitch>
141144
<template v-if="writeNoteToRecipientIsChecked">
142145
<textarea :value="share.note" @input="share.note = $event.target.value" />
143146
</template>
144147
<NcCheckboxRadioSwitch :checked.sync="setCustomPermissions">
145-
{{ t('file_sharing', 'Custom permissions') }}
148+
{{ t('files_sharing', 'Custom permissions') }}
146149
</NcCheckboxRadioSwitch>
147150
<section v-if="setCustomPermissions" class="custom-permissions-group">
148151
<NcCheckboxRadioSwitch :disabled="!allowsFileDrop && share.type === SHARE_TYPES.SHARE_TYPE_LINK"
149152
:checked.sync="hasRead">
150-
{{ t('file_sharing', 'Read') }}
153+
{{ t('files_sharing', 'Read') }}
151154
</NcCheckboxRadioSwitch>
152155
<NcCheckboxRadioSwitch v-if="isFolder" :disabled="!canSetCreate" :checked.sync="canCreate">
153-
{{ t('file_sharing', 'Create') }}
156+
{{ t('files_sharing', 'Create') }}
154157
</NcCheckboxRadioSwitch>
155158
<NcCheckboxRadioSwitch :disabled="!canSetEdit" :checked.sync="canEdit">
156-
{{ t('file_sharing', 'Update') }}
159+
{{ t('files_sharing', 'Update') }}
157160
</NcCheckboxRadioSwitch>
158161
<NcCheckboxRadioSwitch v-if="config.isResharingAllowed && share.type !== SHARE_TYPES.SHARE_TYPE_LINK"
159162
:disabled="!canSetReshare"
160163
:checked.sync="canReshare">
161-
{{ t('file_sharing', 'Share') }}
164+
{{ t('files_sharing', 'Share') }}
162165
</NcCheckboxRadioSwitch>
163166
<NcCheckboxRadioSwitch :disabled="!canSetDelete" :checked.sync="canDelete">
164-
{{ t('file_sharing', 'Delete') }}
167+
{{ t('files_sharing', 'Delete') }}
165168
</NcCheckboxRadioSwitch>
166169
</section>
167170
</section>
@@ -181,7 +184,7 @@
181184
</NcButton>
182185
<div class="button-group">
183186
<NcButton @click="$emit('close-sharing-details')">
184-
{{ t('file_sharing', 'Cancel') }}
187+
{{ t('files_sharing', 'Cancel') }}
185188
</NcButton>
186189
<NcButton type="primary" @click="saveShare">
187190
{{ shareButtonText }}
@@ -477,9 +480,9 @@ export default {
477480
},
478481
shareButtonText() {
479482
if (this.isNewShare) {
480-
return t('file_sharing', 'Save share')
483+
return t('files_sharing', 'Save share')
481484
}
482-
return t('file_sharing', 'Update share')
485+
return t('files_sharing', 'Update share')
483486
484487
},
485488
/**

dist/files_sharing-files_sharing_tab.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/files_sharing-files_sharing_tab.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)