Skip to content

Commit 14f2863

Browse files
author
Julien Veyssier
committed
avoid 'No users in here' in user list when there actually are users
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
1 parent 702bced commit 14f2863

2 files changed

Lines changed: 15 additions & 8 deletions

File tree

apps/settings/src/components/UserList.vue

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -459,8 +459,13 @@ export default {
459459
group: this.selectedGroup !== 'disabled' ? this.selectedGroup : '',
460460
search: this.searchQuery,
461461
})
462-
.then((response) => {
463-
response ? $state.loaded() : $state.complete()
462+
.then((usersCount) => {
463+
if (usersCount > 0) {
464+
$state.loaded()
465+
}
466+
if (usersCount < this.usersLimit) {
467+
$state.complete()
468+
}
464469
})
465470
},
466471

apps/settings/src/store/users.js

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -224,11 +224,12 @@ const actions = {
224224
cancelToken: searchRequestCancelSource.token,
225225
})
226226
.then((response) => {
227-
if (Object.keys(response.data.ocs.data.users).length > 0) {
227+
const usersCount = Object.keys(response.data.ocs.data.users).length
228+
if (usersCount > 0) {
228229
context.commit('appendUsers', response.data.ocs.data.users)
229-
return Object.keys(response.data.ocs.data.users).length >= limit
230+
return usersCount
230231
}
231-
return false
232+
return 0
232233
})
233234
.catch((error) => {
234235
if (!axios.isCancel(error)) {
@@ -241,11 +242,12 @@ const actions = {
241242
cancelToken: searchRequestCancelSource.token,
242243
})
243244
.then((response) => {
244-
if (Object.keys(response.data.ocs.data.users).length > 0) {
245+
const usersCount = Object.keys(response.data.ocs.data.users).length
246+
if (usersCount > 0) {
245247
context.commit('appendUsers', response.data.ocs.data.users)
246-
return Object.keys(response.data.ocs.data.users).length >= limit
248+
return usersCount
247249
}
248-
return false
250+
return 0
249251
})
250252
.catch((error) => {
251253
if (!axios.isCancel(error)) {

0 commit comments

Comments
 (0)