Skip to content

Commit de87ad1

Browse files
Merge pull request #76 from nextcloud/backport/65/stable25
[stable25] ignore exception on unknown entity
2 parents 3c8a2ae + 18ac87b commit de87ad1

3 files changed

Lines changed: 15 additions & 4 deletions

File tree

lib/RelatedResourceProviders/CalendarRelatedResourceProvider.php

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -205,6 +205,12 @@ private function generateSingleId(CalendarShare $share): void {
205205
}
206206

207207

208+
/**
209+
* @param string $principalUri
210+
*
211+
* @return FederatedUser
212+
* @throws Exception
213+
*/
208214
private function extractEntity(string $principalUri): FederatedUser {
209215
[$shareType, $recipient] = explode('/', substr($principalUri, 11), 2);
210216

lib/RelatedResourceProviders/DeckRelatedResourceProvider.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,10 @@ private function convertToRelatedResource(DeckShare $share): IRelatedResource {
173173
*/
174174
private function assignEntities(array $shares): void {
175175
foreach ($shares as $share) {
176-
$this->assignEntity($share);
176+
try {
177+
$this->assignEntity($share);
178+
} catch (Exception $e) {
179+
}
177180
}
178181
}
179182

lib/RelatedResourceProviders/TalkRelatedResourceProvider.php

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -104,8 +104,7 @@ public function getRelatedToEntity(FederatedUser $entity): array {
104104
switch ($entity->getBasedOn()->getSource()) {
105105
case Member::TYPE_USER:
106106
$shares = $this->talkRoomRequest->getSharesToUser($entity->getUserId());
107-
108-
return [];
107+
break;
109108

110109
case Member::TYPE_GROUP:
111110
$shares = $this->talkRoomRequest->getSharesToGroup($entity->getUserId());
@@ -168,7 +167,10 @@ private function convertToRelatedResource(TalkRoom $share): IRelatedResource {
168167
*/
169168
private function assignEntities(array $shares): void {
170169
foreach ($shares as $share) {
171-
$this->assignEntity($share);
170+
try {
171+
$this->assignEntity($share);
172+
} catch (Exception $e) {
173+
}
172174
}
173175
}
174176

0 commit comments

Comments
 (0)