chore: Fix psalm issue from rector

Signed-off-by: Louis Chemineau <[email protected]>

Author: artonge

lib/Controller/AlbumsController.php

@@ -149,7 +149,7 @@ private function validFile(File $file, bool $shared): bool {
 
 	private function isShared(Node $node): bool {
 		return $node->getStorage()->instanceOfStorage(SharedStorage::class) ||
-			$node->getStorage()->instanceOfStorage(GroupFolderStorage::class);
+			$node->getStorage()->instanceOfStorage(\OCA\GroupFolders\Mount\GroupFolderStorage::class);
 	}
 
 	private function scanFolder(Folder $folder, int $depth, bool $shared): bool {

lib/Sabre/Album/PublicAlbumPhoto.php

@@ -12,12 +12,10 @@
 use Sabre\DAV\IFile;
 
 class PublicAlbumPhoto extends AlbumPhoto implements IFile {
-	/** @return void */
 	public function delete(): never {
 		throw new NotFoundException('Deleting photos from a public album is not allowed.');
 	}
 
-	/** @return void */
 	public function put($data): never {
 		throw new NotFoundException('Changing a photo from a public album is not allowed.');
 	}

lib/Sabre/Album/PublicAlbumRoot.php

@@ -14,16 +14,10 @@
 use Sabre\DAV\INode;
 
 class PublicAlbumRoot extends AlbumRoot {
-	/**
-	 * @return void
-	 */
 	public function delete(): never {
 		throw new Forbidden('Not allowed to delete a public album');
 	}
 
-	/**
-	 * @return void
-	 */
 	public function setName($name): never {
 		throw new Forbidden('Not allowed to rename a public album');
 	}

lib/Sabre/Album/SharedAlbumRoot.php

@@ -37,16 +37,10 @@ public function __construct(
 		);
 	}
 
-	/**
-	 * @return void
-	 */
 	public function delete() {
 		$this->albumMapper->deleteUserFromAlbumCollaboratorsList($this->userId, $this->album->getAlbum()->getId());
 	}
 
-	/**
-	 * @return void
-	 */
 	public function setName($name): never {
 		throw new Forbidden('Not allowed to rename a shared album');
 	}

lib/Sabre/PhotosHome.php

@@ -46,7 +46,8 @@ public function delete(): never {
 	}
 
 	public function getName(): string {
-		[, $name] = preg_split($this->principalInfo['uri']);
+		[, $name] = \Sabre\Uri\split($this->principalInfo['uri']);
+
 		return $name;
 	}
 

lib/Sabre/RootCollection.php

@@ -47,7 +47,7 @@ public function __construct(
 	 * @param array $principalInfo
 	 */
 	public function getChildForPrincipal(array $principalInfo): PhotosHome {
-		[, $name] = preg_split($principalInfo['uri']);
+		[, $name] = \Sabre\Uri\split($principalInfo['uri']);
 		$user = $this->userSession->getUser();
 		if (is_null($user) || $name !== $user->getUID()) {
 			throw new Forbidden();