From 28681522235c17a15ea0e341b8a652a83124aab9 Mon Sep 17 00:00:00 2001
From: Roeland Jago Douma <roeland@famdouma.nl>
Date: Mon, 12 Apr 2021 19:56:21 +0200
Subject: [PATCH 1/3] By default enable HIBP check

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
---
 lib/PasswordPolicyConfig.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PasswordPolicyConfig.php b/lib/PasswordPolicyConfig.php
index e13f87a1..fc99a2b9 100644
--- a/lib/PasswordPolicyConfig.php
+++ b/lib/PasswordPolicyConfig.php
@@ -164,7 +164,7 @@ public function getEnforceHaveIBeenPwned(): bool {
 		return $this->config->getAppValue(
 			'password_policy',
 			'enforceHaveIBeenPwned',
-			'0'
+			'1'
 		) === '1';
 	}
 

From c735836b3dbd9e1702f5f73c08f7a2d9479aadc9 Mon Sep 17 00:00:00 2001
From: Lukas Reschke <lukas@statuscode.ch>
Date: Tue, 25 May 2021 16:33:17 +0200
Subject: [PATCH 2/3] Disable HIPB if the server has no internet connection

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
---
 lib/PasswordPolicyConfig.php | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/lib/PasswordPolicyConfig.php b/lib/PasswordPolicyConfig.php
index fc99a2b9..d05828e3 100644
--- a/lib/PasswordPolicyConfig.php
+++ b/lib/PasswordPolicyConfig.php
@@ -161,6 +161,11 @@ public function setEnforceSpecialCharacters(bool $enforceSpecialCharacters) {
 	 * @return bool
 	 */
 	public function getEnforceHaveIBeenPwned(): bool {
+		$hasInternetConnection = $this->config->getSystemValue('has_internet_connection', true);
+		if(!$hasInternetConnection) {
+			return false;
+		}
+
 		return $this->config->getAppValue(
 			'password_policy',
 			'enforceHaveIBeenPwned',

From e2ce0acd454000895eba00252b3833e7aee49b39 Mon Sep 17 00:00:00 2001
From: Morris Jobke <hey@morrisjobke.de>
Date: Tue, 25 May 2021 16:42:11 +0200
Subject: [PATCH 3/3] Fix code style

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
---
 lib/PasswordPolicyConfig.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PasswordPolicyConfig.php b/lib/PasswordPolicyConfig.php
index d05828e3..54fea992 100644
--- a/lib/PasswordPolicyConfig.php
+++ b/lib/PasswordPolicyConfig.php
@@ -162,7 +162,7 @@ public function setEnforceSpecialCharacters(bool $enforceSpecialCharacters) {
 	 */
 	public function getEnforceHaveIBeenPwned(): bool {
 		$hasInternetConnection = $this->config->getSystemValue('has_internet_connection', true);
-		if(!$hasInternetConnection) {
+		if (!$hasInternetConnection) {
 			return false;
 		}