test: Remove debug logs triggered by the testing app

Signed-off-by: Joas Schilling <coding@schilljs.com>

Author: nickvergessen

tests/Integration/app/appinfo/info.xml

@@ -27,6 +27,6 @@
 	<repository>https://github.com/nextcloud/notifications.git</repository>
 
 	<dependencies>
-		<nextcloud min-version="28" max-version="28" />
+		<nextcloud min-version="32" max-version="32" />
 	</dependencies>
 </info>

tests/Integration/app/appinfo/routes.php

@@ -3,7 +3,7 @@
 declare(strict_types=1);
 /**
  * SPDX-FileCopyrightText: 2021 Nextcloud GmbH and Nextcloud contributors
- * SPDX-License-Identifier: AGPL-3.0-only
+ * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
 namespace OCA\NotificationsIntegrationTesting\AppInfo;

tests/Integration/app/lib/AppInfo/Application.php

@@ -1,57 +1,50 @@
 <?php
+
+declare(strict_types=1);
 /**
+ * SPDX-FileCopyrightText: 2016-2024 Nextcloud GmbH and Nextcloud contributors
  * SPDX-FileCopyrightText: 2016 ownCloud, Inc.
  * SPDX-License-Identifier: AGPL-3.0-only
  */
 
 namespace OCA\NotificationsIntegrationTesting\Controller;
 
+use OCP\AppFramework\Http\Attribute\ApiRoute;
+use OCP\AppFramework\Http\Attribute\NoCSRFRequired;
 use OCP\AppFramework\Http\DataResponse;
 use OCP\AppFramework\OCSController;
 use OCP\IRequest;
 use OCP\Notification\IManager;
 
 class EndpointController extends OCSController {
-	/** @var IManager */
-	private $manager;
-
-	/**
-	 * @param string $appName
-	 * @param IRequest $request
-	 * @param IManager $manager
-	 */
-	public function __construct($appName, IRequest $request, IManager $manager) {
+	public function __construct(
+		string $appName,
+		IRequest $request,
+		protected IManager $manager,
+	) {
 		parent::__construct($appName, $request);
-		$this->manager = $manager;
 	}
 
-	/**
-	 * @NoCSRFRequired
-	 *
-	 * @param string $userId
-	 * @return DataResponse
-	 */
-	public function addNotification(string $userId = 'test1') {
+	#[NoCSRFRequired]
+	#[ApiRoute(verb: 'POST', url: '/notifications')]
+	public function addNotification(string $userId = 'test1'): DataResponse {
 		$notification = $this->manager->createNotification();
 		$notification->setApp($this->request->getParam('app', 'notificationsintegrationtesting'))
-			->setDateTime(\DateTime::createFromFormat('U', $this->request->getParam('timestamp', 1449585176))) // 2015-12-08T14:32:56+00:00
+			->setDateTime(\DateTime::createFromFormat('U', (string)$this->request->getParam('timestamp', '1449585176'))) // 2015-12-08T14:32:56+00:00
 			->setUser($this->request->getParam('user', $userId))
 			->setSubject($this->request->getParam('subject', 'testing'))
 			->setLink($this->request->getParam('link', 'https://example.tld/'))
 			->setMessage($this->request->getParam('message', 'message'))
-			->setObject($this->request->getParam('object_type', 'object'), $this->request->getParam('object_id', 23));
+			->setObject($this->request->getParam('object_type', 'object'), (string)$this->request->getParam('object_id', '23'));
 
 		$this->manager->notify($notification);
 
 		return new DataResponse();
 	}
 
-	/**
-	 * @NoCSRFRequired
-	 *
-	 * @return DataResponse
-	 */
-	public function deleteNotifications() {
+	#[NoCSRFRequired]
+	#[ApiRoute(verb: 'DELETE', url: '')]
+	public function deleteNotifications(): DataResponse {
 		$notification = $this->manager->createNotification();
 		$this->manager->markProcessed($notification);
 

tests/Integration/app/lib/Controller/EndpointController.php

@@ -1,5 +1,8 @@
 <?php
+
+declare(strict_types=1);
 /**
+ * SPDX-FileCopyrightText: 2016-2024 Nextcloud GmbH and Nextcloud contributors
  * SPDX-FileCopyrightText: 2016 ownCloud, Inc.
  * SPDX-License-Identifier: AGPL-3.0-only
  */
@@ -8,41 +11,24 @@
 
 use OCP\Notification\INotification;
 use OCP\Notification\INotifier;
+use OCP\Notification\UnknownNotificationException;
 
 class Notifier implements INotifier {
-	/**
-	 * Identifier of the notifier, only use [a-z0-9_]
-	 *
-	 * @return string
-	 * @since 17.0.0
-	 */
 	public function getID(): string {
 		return 'notificationsintegrationtesting';
 	}
 
-	/**
-	 * Human readable name describing the notifier
-	 *
-	 * @return string
-	 * @since 17.0.0
-	 */
 	public function getName(): string {
 		return 'Integration test';
 	}
 
-	/**
-	 * @param INotification $notification
-	 * @param string $languageCode The code of the language that should be used to prepare the notification
-	 * @return INotification
-	 * @throws \InvalidArgumentException When the notification was not prepared by a notifier
-	 */
 	public function prepare(INotification $notification, string $languageCode): INotification {
 		if ($notification->getApp() === 'notificationsintegrationtesting') {
 			$notification->setParsedSubject($notification->getSubject());
 			$notification->setParsedMessage($notification->getMessage());
 			return $notification;
 		}
 
-		throw new \InvalidArgumentException();
+		throw new UnknownNotificationException();
 	}
 }