Merge pull request #733 from nextcloud/artonge/dept/own_is-encrypted

feat: Own the handling of the is-encrypted DAV property

Author: artonge

lib/Connector/Sabre/PropFindPlugin.php

@@ -37,6 +37,8 @@
 use Sabre\HTTP\RequestInterface;
 
 class PropFindPlugin extends APlugin {
+	public const IS_ENCRYPTED_PROPERTYNAME = '{http://nextcloud.org/ns}is-encrypted';
+
 	private UserAgentManager $userAgentManager;
 	private IRequest $request;
 	protected ?Server $server = null;
@@ -59,9 +61,19 @@ public function initialize(Server $server) {
 
 		$this->server = $server;
 		$this->server->on('afterMethod:PROPFIND', [$this, 'checkAccess'], 50);
+		$this->server->on('propFind', [$this, 'setEncryptedProperty'], 104);
 		$this->server->on('propFind', [$this, 'updateProperty'], 105);
 	}
 
+	public function setEncryptedProperty(PropFind $propFind, \Sabre\DAV\INode $node) {
+		// Only folders can be e2e encrypted, so we only respond for directories.
+		if ($node instanceof Directory) {
+			$propFind->handle(self::IS_ENCRYPTED_PROPERTYNAME, function () use ($node) {
+				return $node->getFileInfo()->isEncrypted() ? '1' : '0';
+			});
+		}
+	}
+
 	/**
 	 * Remove permissions of end-to-end encrypted files for unsupported clients
 	 *

tests/Unit/Connector/Sabre/PropFindPluginTest.php

@@ -86,6 +86,7 @@ public function testInitialize(): void {
 			->method('on')
 			->withConsecutive(
 				['afterMethod:PROPFIND', [$this->plugin, 'checkAccess'], 50],
+				['propFind', [$this->plugin, 'setEncryptedProperty'], 104],
 				['propFind', [$this->plugin, 'updateProperty'], 105],
 			);
 

tests/stub.phpstub

@@ -65,6 +65,7 @@ namespace Sabre\DAV {
         public function set(string $key, string $value, int $stuff) {}
         public function getPath(): string {}
         public function setPath(string $string): void {}
+	    public function handle($propertyName, $valueOrCallBack)
     }
 
     class Server {