Skip to content

chore(lint): fix lint warnings #4995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hamza221 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore(lint): fix lint warnings #4995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/AppContent/CircleContent.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export default {
props: {
loading: {
type: Boolean,
default: true,
default: false,
},
},

Expand Down
4 changes: 3 additions & 1 deletion src/components/AppContent/ContactsContent.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ export default {
props: {
loading: {
type: Boolean,
default: true,
default: false,
},

contactsList: {
Expand All @@ -97,6 +97,8 @@ export default {
},
},

emits: ['new-contact'],

data() {
return {
searchQuery: '',
Expand Down
2 changes: 2 additions & 0 deletions src/components/AppNavigation/ContactsSettings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ export default {
},
},

emits: ['update:open', 'clicked', 'file-loaded'],

data() {
return {
allowSocialSync: loadState('contacts', 'allowSocialSync') !== 'no',
Expand Down
6 changes: 4 additions & 2 deletions src/components/AppNavigation/GroupNavigationItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,8 @@ export default {
},
},

emits: ['updateRouteState'],

data() {
return {
newGroupName: '',
Expand Down Expand Up @@ -248,8 +250,8 @@ export default {
/**
* Open mailto: for contacts in a group
*
* @param {object} group of contacts to be emailed
* @param {string} mode
* @param {object} group contacts to be emailed
* @param {string} mode the email mode
*/
emailGroup(group, mode = 'to') {
const emails = []
Expand Down
1 change: 0 additions & 1 deletion src/components/AppNavigation/Settings/SettingsImportContacts.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
</NcButton>
<Modal
v-if="isOpened"
ref="modal"
class="import-contact__modal"
:name="t('contacts', 'Import contacts')"
@close="toggleModal">
Expand Down
5 changes: 0 additions & 5 deletions src/components/ChartTemplate.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,6 @@ export default {
type: Object,
default: () => {},
},

onAvatarClick: {
type: Function,
default: () => {},
},
},

computed: {
Expand Down
4 changes: 2 additions & 2 deletions src/components/CircleDetails.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,10 +666,10 @@ export default {
},

/**
* Autocomplete @mentions on the description
* Autocomplete \@mentions on the description
*
* @param {string} search the search term
* @param {Function} callback callback to be called with results array
* @param {(results: Array) => void} callback callback to be called with results array
*/
onAutocomplete(search, callback) {
// TODO: implement autocompletion. Disabled for now
Expand Down
2 changes: 1 addition & 1 deletion src/components/ConfirmationDialog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export default {

disabled: {
type: Boolean,
default: undefined,
default: false,
},
},

Expand Down
12 changes: 5 additions & 7 deletions src/components/ContactDetails.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
<!-- org, title -->
<template #subtitle>
<template v-if="isReadOnly">
<span v-html="formattedSubtitle" />
<span :innerHTML="formattedSubtitle" />
</template>
<template v-else>
<input
Expand Down Expand Up @@ -97,14 +97,14 @@
</template>
</ActionButton>
<ActionLink
v-for="emailAddress in emailAddressList"
:key="emailAddress"
v-for="email in emailAddressList"
:key="email"
class="quick-action"
:href="'mailto:' + emailAddress">
:href="'mailto:' + email">
<template #icon>
<IconMail :size="20" />
</template>
{{ emailAddress }}
{{ email }}
</ActionLink>
<ActionLink
v-for="phoneNumber in phoneNumberList"
Expand Down Expand Up @@ -181,7 +181,6 @@
<!-- user can clone if there is at least one option available -->
<ActionButton
v-if="isReadOnly && addressbooksOptions.length > 0"
ref="cloneAction"
:close-after-click="true"
@click="cloneContact">
<template #icon>
Expand Down Expand Up @@ -239,7 +238,6 @@
:name="t('contacts', 'Pick an address book')"
@close="closePickAddressbookModal">
<NcSelect
ref="pickAddressbook"
v-model="pickedAddressbook"
class="address-book"
:allow-empty="false"
Expand Down
2 changes: 2 additions & 0 deletions src/components/ContactDetails/ContactDetailsAvatar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,8 @@ export default {
},
},

emits: ['update-local-contact'],

data() {
return {
opened: false,
Expand Down
5 changes: 0 additions & 5 deletions src/components/ContactDetails/ContactDetailsProperty.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,6 @@ export default {
default: null,
},

contacts: {
type: Array,
default: () => [],
},

bus: {
type: Object,
required: true,
Expand Down
2 changes: 2 additions & 0 deletions src/components/ContactsList/Merging.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,8 @@ export default {
},
},

emits: ['finished'],

data() {
return {
bus: mitt(),
Expand Down
1 change: 0 additions & 1 deletion src/components/DetailsHeader.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@

<!-- menu actions -->
<Actions
ref="actions"
class="header-menu"
menu-align="right"
v-bind="$attrs">
Expand Down
2 changes: 2 additions & 0 deletions src/components/EntityPicker/EntityBubble.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ export default {
},
},

emits: ['delete'],

methods: {
onDelete() {
// Emit delete. Be aware it might be unique
Expand Down
12 changes: 3 additions & 9 deletions src/components/EntityPicker/EntityPicker.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,14 +175,6 @@ export default {
},
},

/**
* The sorting key for the dataSet
*/
sort: {
type: String,
default: 'label',
},

/**
* Confirm button text
*/
Expand All @@ -205,7 +197,7 @@ export default {
*/
internalSearch: {
type: Boolean,
default: true,
default: false,
},

/**
Expand All @@ -223,6 +215,8 @@ export default {
},
},

emits: ['update:selection', 'close', 'submit', 'search'],

data() {
return {
canInviteGuests: !!window?.OCA?.Guests?.openGuestDialog,
Expand Down
2 changes: 2 additions & 0 deletions src/components/EntityPicker/NewCircleIntro.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@ export default {
},
},

emits: ['close', 'submit'],

data() {
return {
circleName: '',
Expand Down
2 changes: 2 additions & 0 deletions src/components/MemberList/MemberList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ import { t } from '@nextcloud/l10n'
import { NcEmptyContent } from '@nextcloud/vue'
import { defineComponent } from 'vue'
import IconContact from 'vue-material-design-icons/AccountMultipleOutline.vue'
import IconLoading from 'vue-material-design-icons/Loading.vue'
import EntityPicker from '../EntityPicker/EntityPicker.vue'
import MemberGridItem from './MemberGridItem.vue'
import IsMobileMixin from '../../mixins/IsMobileMixin.ts'
Expand All @@ -74,6 +75,7 @@ export default defineComponent({
components: {
EntityPicker,
IconContact,
IconLoading,
MemberGridItem,
NcEmptyContent,
},
Expand Down
2 changes: 2 additions & 0 deletions src/components/MemberList/MemberListItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ import {
NcActionSeparator,
NcActionText,
NcAvatar,
NcButton,
NcListItem,
} from '@nextcloud/vue'
import IconCheck from 'vue-material-design-icons/Check.vue'
Expand All @@ -113,6 +114,7 @@ export default {
NcActionSeparator,
NcActionText,
NcAvatar,
NcButton,
},

mixins: [RouterMixin],
Expand Down
1 change: 1 addition & 0 deletions src/components/OrgChart.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
</template>

<script>
/* eslint-disable vue/one-component-per-file */
import { getLocale } from '@nextcloud/l10n'
import { NcSelect } from '@nextcloud/vue'
import * as d3 from 'd3'
Expand Down
2 changes: 2 additions & 0 deletions src/components/Properties/PropertyActions.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ export default {
},
},

emits: ['delete'],

methods: {
deleteProperty() {
this.$emit('delete')
Expand Down
2 changes: 2 additions & 0 deletions src/components/Properties/PropertyDateTime.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,8 @@ export default {
},
},

emits: ['update:value'],

data() {
return {
// input type following DatePicker docs
Expand Down
7 changes: 2 additions & 5 deletions src/components/Properties/PropertyGroups.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,18 +83,15 @@ export default {
required: true,
},

contact: {
type: Contact,
required: true,
},

// Is it read-only?
isReadOnly: {
type: Boolean,
required: true,
},
},

emits: ['update:value'],

data() {
return {
localValue: [...this.value].sort(),
Expand Down
2 changes: 1 addition & 1 deletion src/components/Properties/PropertyMultipleText.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@
<!-- no order enforced: just iterate on all the values -->
<template v-else>
<div
v-for="(value, index) in filteredValue"
v-for="(item, index) in filteredValue"
:key="index"
class="property__row">
<template v-if="(isReadOnly && filteredValue[index]) || !isReadOnly">
Expand Down
5 changes: 0 additions & 5 deletions src/components/Properties/PropertySelect.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,6 @@ export default {
mixins: [PropertyMixin],

props: {
value: {
type: [Object, String, Array],
required: true,
},

hideActions: {
type: Boolean,
default: false,
Expand Down
5 changes: 0 additions & 5 deletions src/components/Properties/PropertyText.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,11 +142,6 @@ export default {
type: String,
default: 'text',
},

value: {
type: String,
required: true,
},
},

data() {
Expand Down
1 change: 1 addition & 0 deletions src/components/Properties/PropertyTitle.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ export default {
bus: {
type: Object,
required: false,
default: () => ({}),
},
},

Expand Down
8 changes: 4 additions & 4 deletions src/models/circle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export default class Circle {
/**
* Creates an instance of Circle
*
* @param data
* @param data the circle data
*/
constructor(data: object) {
this.updateData(data)
Expand All @@ -26,7 +26,7 @@ export default class Circle {
/**
* Update inner circle data, owner and initiator
*
* @param data
* @param data the circle data to update
*/
updateData(data: any) {
if (typeof data !== 'object') {
Expand Down Expand Up @@ -151,7 +151,7 @@ export default class Circle {
/**
* Add a member to this circle
*
* @param member
* @param member the member to add
*/
addMember(member: Member) {
if (member.constructor.name !== Member.name) {
Expand All @@ -168,7 +168,7 @@ export default class Circle {
/**
* Remove a member from this circle
*
* @param member
* @param member the member to remove
*/
deleteMember(member: Member) {
if (member.constructor.name !== Member.name) {
Expand Down
4 changes: 2 additions & 2 deletions src/models/member.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ export default class Member {
/**
* Creates an instance of Member
*
* @param data
* @param circle
* @param data the member data
* @param circle the circle this member belongs to
*/
constructor(data: any, circle: Circle) {
if (typeof data !== 'object') {
Expand Down
Loading
Loading