Skip to content

Commit 1feb135

Browse files
committed
refactor: sources as computed prop
Signed-off-by: Jana Peper <[email protected]>
1 parent 8112bb6 commit 1feb135

1 file changed

Lines changed: 10 additions & 9 deletions

File tree

src/components/ChattyLLM/Message.vue

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
{{ message.role === 'human' ? displayName : t('assistant', 'Nextcloud Assistant') }}
3232
</div>
3333
<div style="display: flex">
34-
<NcPopover v-if="sources.length">
34+
<NcPopover v-if="parsedSources.length">
3535
<template #trigger>
3636
<NcButton
3737
:aria-label="t('assistant', 'Information sources')">
@@ -44,7 +44,7 @@
4444
<div class="toolinfo_popover_inner">
4545
<h6> Information sources </h6>
4646
<ul>
47-
<li v-for="source in sources" :key="source">
47+
<li v-for="source in parsedSources" :key="source">
4848
{{ source }}
4949
</li>
5050
</ul>
@@ -141,13 +141,19 @@ export default {
141141
// with [] we inhibit the extract+resolve mechanism on NcRichText
142142
// TODO This can be removed (and all the custom extract+resolve logic) when fixed in NcRichText
143143
references: [],
144-
sources: [],
145144
}
146145
},
147146
147+
computed: {
148+
parsedSources() {
149+
let parsedSources = JSON.parse(this.message.sources)
150+
parsedSources = parsedSources.map((source) => this.getSourceString(source))
151+
return [...new Set(parsedSources)]
152+
},
153+
},
154+
148155
mounted() {
149156
this.fetch()
150-
this.sources = this.parse_sources()
151157
},
152158
153159
methods: {
@@ -176,11 +182,6 @@ export default {
176182
getSourceString(source) {
177183
return this.informationSourceNames[source] ? this.informationSourceNames[source] : source
178184
},
179-
parse_sources() {
180-
let parsedSources = JSON.parse(this.message.sources)
181-
parsedSources = parsedSources.map((source) => this.getSourceString(source))
182-
return [...new Set(parsedSources)]
183-
},
184185
},
185186
}
186187
</script>

0 commit comments

Comments
 (0)