Skip to content

Commit 396dccb

Browse files
authored
Merge pull request #760 from nextcloud/feat/HaRP/AIO
fix(HaRP-AIO): FRP should be always disabled for the HaRP AIO template
2 parents eff794c + 7805ffe commit 396dccb

File tree

4 files changed

+8
-5
lines changed

4 files changed

+8
-5
lines changed

js/app_api-adminSettings.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

js/app_api-adminSettings.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/components/DaemonConfig/ManageDaemonConfigModal.vue

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,10 +133,10 @@
133133
<NcFormBoxSwitch
134134
v-model="deployConfig.harp.exapp_direct"
135135
class="switch"
136-
:disabled="isEdit">
136+
:disabled="isEdit || isHarpAio">
137137
{{ t('app_api', 'Disable FRP') }}
138138
</NcFormBoxSwitch>
139-
<InfoTooltip :text="t('app_api', 'Flag for advanced setups only. Disables the FRP tunnel between ExApps and HaRP.')" />
139+
<InfoTooltip :text="isHarpAio ? t('app_api', 'FRP is always disabled for the All-in-One setup.') : t('app_api', 'Flag for advanced setups only. Disables the FRP tunnel between ExApps and HaRP.')" />
140140
</div>
141141
</div>
142142
<template v-if="!isPureManual">
@@ -533,6 +533,9 @@ export default {
533533
isHarp() {
534534
return this.deployConfig.harp !== null
535535
},
536+
isHarpAio() {
537+
return this.configurationTab?.id === 'harp_aio'
538+
},
536539
isPureManual() {
537540
return this.acceptsDeployId === 'manual-install' && !this.isHarp
538541
},

src/constants/daemonTemplates.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ export const DAEMON_TEMPLATES = [
8282
harp: {
8383
frp_address: 'nextcloud-aio-harp:8782',
8484
docker_socket_port: 24000,
85-
exapp_direct: false,
85+
exapp_direct: true,
8686
},
8787
},
8888
deployConfigSettingsOpened: false,

0 commit comments

Comments
 (0)