-
Notifications
You must be signed in to change notification settings - Fork 5
feat(FilePicker): Improve pick and navigation logic to match user expectation #2033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2033 +/- ##
==========================================
- Coverage 49.93% 49.32% -0.62%
==========================================
Files 22 22
Lines 803 813 +10
Branches 102 102
==========================================
Hits 401 401
- Misses 401 411 +10
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a0c341f to
543281c
Compare
susnux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just insist on the CSS one, the other comment is just an idea.
Meaning otherwise its really nice!
543281c to
9303c0d
Compare
Signed-off-by: Louis Chmn <[email protected]>
e80123a to
896ce75
Compare
This will inhibit selection of nodes Signed-off-by: Louis Chmn <[email protected]>
Signed-off-by: Louis Chmn <[email protected]>
896ce75 to
9895f85
Compare
canPick option to gray out nodes2b6e341 to
99fd682
Compare
19437c4 to
d3bbe36
Compare
Signed-off-by: Louis Chmn <[email protected]>
Signed-off-by: Louis Chmn <[email protected]>
896732a to
c6dd72c
Compare
|
/backport to stable6 |
canPickoption