Skip to content

Conversation

@artonge
Copy link
Contributor

@artonge artonge commented Oct 16, 2025

  • Set cursor as pointer on file rows
  • Expose new canPick option
  • Prevent navigation to non-readable nodes
Before After
image Screenshot From 2025-10-17 11-17-19

@artonge artonge self-assigned this Oct 16, 2025
@artonge artonge added enhancement New feature or request 3. to review file picker javascript Pull requests that update javascript code labels Oct 16, 2025
@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.32%. Comparing base (b040333) to head (c6dd72c).
⚠️ Report is 33 commits behind head on main.

Files with missing lines Patch % Lines
lib/filepicker-builder.ts 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2033      +/-   ##
==========================================
- Coverage   49.93%   49.32%   -0.62%     
==========================================
  Files          22       22              
  Lines         803      813      +10     
  Branches      102      102              
==========================================
  Hits          401      401              
- Misses        401      411      +10     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@artonge artonge force-pushed the artonge/feat/add_canpick_option branch from a0c341f to 543281c Compare October 16, 2025 10:38
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just insist on the CSS one, the other comment is just an idea.
Meaning otherwise its really nice!

@artonge artonge force-pushed the artonge/feat/add_canpick_option branch from 543281c to 9303c0d Compare October 16, 2025 11:46
@artonge artonge force-pushed the artonge/feat/add_canpick_option branch 2 times, most recently from e80123a to 896ce75 Compare October 16, 2025 13:37
This will inhibit selection of nodes

Signed-off-by: Louis Chmn <[email protected]>
@artonge artonge force-pushed the artonge/feat/add_canpick_option branch from 896ce75 to 9895f85 Compare October 17, 2025 09:25
@artonge artonge changed the title feat(FilePicker): Expose canPick option to gray out nodes feat(FilePicker): Improve pick and navigation logic to match user expectation Oct 17, 2025
@artonge artonge force-pushed the artonge/feat/add_canpick_option branch 7 times, most recently from 2b6e341 to 99fd682 Compare October 17, 2025 11:14
@artonge artonge requested a review from susnux October 17, 2025 11:34
@artonge artonge force-pushed the artonge/feat/add_canpick_option branch 2 times, most recently from 19437c4 to d3bbe36 Compare October 17, 2025 13:29
@artonge artonge force-pushed the artonge/feat/add_canpick_option branch 2 times, most recently from 896732a to c6dd72c Compare October 17, 2025 13:42
@artonge artonge merged commit 22f16c3 into main Oct 21, 2025
12 of 17 checks passed
@artonge artonge deleted the artonge/feat/add_canpick_option branch October 21, 2025 08:11
@artonge artonge mentioned this pull request Oct 21, 2025
@artonge
Copy link
Contributor Author

artonge commented Oct 22, 2025

/backport to stable6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review enhancement New feature or request file picker javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants