Allow sessions to be distinguished based on XRDP port configuration at session start using new Policy in sesman.ini #3686
+128
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Remove trailing space
Author
Thanks, no rush at all. Hopefully I will be able to contribute a bit to the project moving forward since we're planning to use it quite a bit at my job. |
Member
|
On a personal note, I got into xrdp coding because I was the UNIX administrator for a network where it was the best solution for what we were doing. So I'm more that happy to help you with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion: #3521
The motivation behind this PR is to allow a user (or an automation script) to maintain multiple distinct sessions based on the port configuration used when the session is started up. The reason for this is to allow xrdp to imitate the behaviour of multiple VNC servers started by users, while allowing a single instance of
xrdp-sesmanto track the sessions, and letting users (or middleware) choose which session to connect to based on the port specified on connection.The specific use-case I have for this integrating
xrdpwith e.g., OpenOnDemand to allow users to start multiple remote desktop sessions without having to worry about breakage if two sessions by coincidence start on the same compute node.In my testing so far, using the new
Ppolicy works just as well as theDpolicy - one has to ensure DBUS and XDG_RUNTIME_DIR don't get in the way of multiple xfce4 sessions, but the distinction of sessions by xrdp port works just fine.This is just my suggestion for how to implement it, I expect that it will have to go through a few rounds of reviewing and editing.