Skip to content

Conversation

@dsikka
Copy link

@dsikka dsikka commented Sep 30, 2024

FILL IN THE PR DESCRIPTION HERE

FIX #xxxx (link existing issues this PR will resolve)

BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE


PR Checklist (Click to Expand)

Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.

PR Title and Classification

Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

  • [Bugfix] for bug fixes.
  • [CI/Build] for build or continuous integration improvements.
  • [Doc] for documentation fixes and improvements.
  • [Model] for adding a new model or improving an existing model. Model name should appear in the title.
  • [Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
  • [Kernel] for changes affecting CUDA kernels or other compute kernels.
  • [Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
  • [Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
  • [Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.

Code Quality

The PR need to meet the following code quality standards:

  • We adhere to Google Python style guide and Google C++ style guide.
  • Pass all linter checks. Please use format.sh to format your code.
  • The code need to be well-documented to ensure future contributors can easily understand the code.
  • Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
  • Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Adding or changing kernels

Each custom kernel needs a schema and one or more implementations to be registered with PyTorch.

  • Make sure custom ops are registered following PyTorch guidelines: Custom C++ and CUDA Operators and The Custom Operators Manual
  • Custom operations that return Tensors require meta-functions. Meta-functions should be implemented and registered in python so that dynamic dims can be handled automatically. See above documents for a description of meta-functions.
  • Use torch.libary.opcheck() to test the function registration and meta-function for any registered ops. See tests/kernels for examples.
  • When changing the C++ signature of an existing op, the schema must be updated to reflect the changes.
  • If a new custom type is needed, see the following document: Custom Class Support in PT2.

Notes for Large Changes

Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.

What to Expect for the Reviews

The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

  • After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
  • After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
  • After the review, the reviewer will put an action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
  • Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You

Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@dsikka dsikka closed this Oct 1, 2024
njhill pushed a commit that referenced this pull request May 2, 2025
* updated

Signed-off-by: [email protected] <[email protected]>

* fix merge

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

---------

Signed-off-by: [email protected] <[email protected]>
tlrmchlsmth added a commit that referenced this pull request May 3, 2025
* [Update] LMcache connector v1 implementation

Signed-off-by: ApostaC <[email protected]>

* [Add] examples for disaggregated prefill

Signed-off-by: ApostaC <[email protected]>

* [add] extra information about evns

Signed-off-by: ApostaC <[email protected]>

* Initial stubs for P/D scheduling changes

Signed-off-by: Tyler Michael Smith <[email protected]>

* Updates

Signed-off-by: Tyler Michael Smith <[email protected]>

* Rs branch (#3)

* updated

Signed-off-by: [email protected] <[email protected]>

* Rs branch (#5)

Signed-off-by: [email protected] <[email protected]>

* Remove Unneeded Arguments (#7)

* updated

Signed-off-by: [email protected] <[email protected]>

* stash

Signed-off-by: [email protected] <[email protected]>

* cleanup

Signed-off-by: [email protected] <[email protected]>

---------

Signed-off-by: [email protected] <[email protected]>

* Improve disagg-example.sh (#8)

- fix spelling
- CUDA_VISIBLE_DEVICES should be set externally

Signed-off-by: Tyler Michael Smith <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* added connector

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* update

Signed-off-by: [email protected] <[email protected]>

* remove

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* seems to load properly

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* Revert "updated"

This reverts commit 97316d9.

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* stash

Signed-off-by: [email protected] <[email protected]>

* added

Signed-off-by: [email protected] <[email protected]>

* diffs for local dev on macos

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* update

Signed-off-by: Robert Shaw <[email protected]>

* updaed

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* Checkpoint.

Signed-off-by: Tyler Michael Smith <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* Cleanup

Signed-off-by: Tyler Michael Smith <[email protected]>

* WIP

Signed-off-by: Tyler Michael Smith <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* updated on scheduler side

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* Hacking away

Signed-off-by: Tyler Michael Smith <[email protected]>

* cleanup

Signed-off-by: Robert Shaw <[email protected]>

* ensure request removed from running list

Signed-off-by: Robert Shaw <[email protected]>

* Runs E2E. Garbage output. Crashes on 2nd request

Signed-off-by: Tyler Michael Smith <[email protected]>

* update

Signed-off-by: Tyler Michael Smith <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* rename files

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* update

Signed-off-by: Robert Shaw <[email protected]>

* Second request no longer crashes

Signed-off-by: Tyler Michael Smith <[email protected]>

* Remove gpu_model_runner hacks

Signed-off-by: Tyler Michael Smith <[email protected]>

* Clean up Justfile

Signed-off-by: Tyler Michael Smith <[email protected]>

* [Bugfix] Stale finished requests in EMPTY_MODEL_RUNNER_OUTPUT

Signed-off-by: Tyler Michael Smith <[email protected]>

* update

Signed-off-by: Tyler Michael Smith <[email protected]>

* justfile edits

Signed-off-by: Tyler Michael Smith <[email protected]>

* Update

Signed-off-by: Tyler Michael Smith <[email protected]>

* Fixes - lm_eval gsm8k has correctness

Signed-off-by: Tyler Michael Smith <[email protected]>

* "just delete the assert"

Signed-off-by: Tyler Michael Smith <[email protected]>

* fixup precommit issues

Signed-off-by: Tyler Michael Smith <[email protected]>

* Fixes

Signed-off-by: Tyler Michael Smith <[email protected]>

* updated (#12)

Signed-off-by: [email protected] <[email protected]>

* Add Accuracy Test (#13)

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

---------

Signed-off-by: [email protected] <[email protected]>

* Preemption Bugfixes (#15)

* stash fixed double free issue

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* fixed issue

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updatrd

Signed-off-by: [email protected] <[email protected]>

* updatrd

Signed-off-by: [email protected] <[email protected]>

* updatrd

Signed-off-by: [email protected] <[email protected]>

* updatrd

Signed-off-by: [email protected] <[email protected]>

* updatrd

Signed-off-by: [email protected] <[email protected]>

* updatrd

Signed-off-by: [email protected] <[email protected]>

---------

Signed-off-by: [email protected] <[email protected]>

* updated (#16)

Signed-off-by: [email protected] <[email protected]>

* Fix Bad Merge | Fix Memory Leak in Upstream (#18)

* updated

Signed-off-by: [email protected] <[email protected]>

* fix merge

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

---------

Signed-off-by: [email protected] <[email protected]>

* clean up justfile, examples

Signed-off-by: Tyler Michael Smith <[email protected]>

* more cleanup

Signed-off-by: Tyler Michael Smith <[email protected]>

* more cleanup

Signed-off-by: Tyler Michael Smith <[email protected]>

* more cleanup

Signed-off-by: Tyler Michael Smith <[email protected]>

* more cleanup

Signed-off-by: Tyler Michael Smith <[email protected]>

* More cleanup

Signed-off-by: Tyler Michael Smith <[email protected]>

* more cleanup

Signed-off-by: Tyler Michael Smith <[email protected]>

* more cleanup, precommit fixes

Signed-off-by: Tyler Michael Smith <[email protected]>

* More cleanup

Signed-off-by: Tyler Michael Smith <[email protected]>

* run_accuracy_test.sh UX

Signed-off-by: Tyler Michael Smith <[email protected]>

* squash warnings

Signed-off-by: Tyler Michael Smith <[email protected]>

* pre-commit

Signed-off-by: Tyler Michael Smith <[email protected]>

* update

Signed-off-by: Tyler Michael Smith <[email protected]>

* Add get_finished to base kv connector

Signed-off-by: mgoin <[email protected]>

* revert test.txt

Signed-off-by: Tyler Michael Smith <[email protected]>

* cleanup

Signed-off-by: Tyler Michael Smith <[email protected]>

* Cleanup

Signed-off-by: Tyler Michael Smith <[email protected]>

* review comments

Signed-off-by: Tyler Michael Smith <[email protected]>

---------

Signed-off-by: ApostaC <[email protected]>
Signed-off-by: Tyler Michael Smith <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: Robert Shaw <[email protected]>
Signed-off-by: mgoin <[email protected]>
Co-authored-by: ApostaC <[email protected]>
Co-authored-by: Robert Shaw <[email protected]>
Co-authored-by: [email protected] <[email protected]>
Co-authored-by: Robert Shaw <[email protected]>
Co-authored-by: mgoin <[email protected]>
Co-authored-by: mgoin <[email protected]>
robertgshaw2-redhat added a commit that referenced this pull request May 4, 2025
* [Update] LMcache connector v1 implementation

Signed-off-by: ApostaC <[email protected]>

* [Add] examples for disaggregated prefill

Signed-off-by: ApostaC <[email protected]>

* [add] extra information about evns

Signed-off-by: ApostaC <[email protected]>

* Initial stubs for P/D scheduling changes

Signed-off-by: Tyler Michael Smith <[email protected]>

* Updates

Signed-off-by: Tyler Michael Smith <[email protected]>

* Rs branch (#3)

* updated

Signed-off-by: [email protected] <[email protected]>

* Rs branch (#5)

Signed-off-by: [email protected] <[email protected]>

* Remove Unneeded Arguments (#7)

* updated

Signed-off-by: [email protected] <[email protected]>

* stash

Signed-off-by: [email protected] <[email protected]>

* cleanup

Signed-off-by: [email protected] <[email protected]>

---------

Signed-off-by: [email protected] <[email protected]>

* Improve disagg-example.sh (#8)

- fix spelling
- CUDA_VISIBLE_DEVICES should be set externally

Signed-off-by: Tyler Michael Smith <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* added connector

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* update

Signed-off-by: [email protected] <[email protected]>

* remove

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* seems to load properly

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* Revert "updated"

This reverts commit 97316d9.

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* stash

Signed-off-by: [email protected] <[email protected]>

* added

Signed-off-by: [email protected] <[email protected]>

* diffs for local dev on macos

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* update

Signed-off-by: Robert Shaw <[email protected]>

* updaed

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* Checkpoint.

Signed-off-by: Tyler Michael Smith <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* Cleanup

Signed-off-by: Tyler Michael Smith <[email protected]>

* WIP

Signed-off-by: Tyler Michael Smith <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* updated on scheduler side

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* Hacking away

Signed-off-by: Tyler Michael Smith <[email protected]>

* cleanup

Signed-off-by: Robert Shaw <[email protected]>

* ensure request removed from running list

Signed-off-by: Robert Shaw <[email protected]>

* Runs E2E. Garbage output. Crashes on 2nd request

Signed-off-by: Tyler Michael Smith <[email protected]>

* update

Signed-off-by: Tyler Michael Smith <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* rename files

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* update

Signed-off-by: Robert Shaw <[email protected]>

* Second request no longer crashes

Signed-off-by: Tyler Michael Smith <[email protected]>

* Remove gpu_model_runner hacks

Signed-off-by: Tyler Michael Smith <[email protected]>

* Clean up Justfile

Signed-off-by: Tyler Michael Smith <[email protected]>

* [Bugfix] Stale finished requests in EMPTY_MODEL_RUNNER_OUTPUT

Signed-off-by: Tyler Michael Smith <[email protected]>

* update

Signed-off-by: Tyler Michael Smith <[email protected]>

* justfile edits

Signed-off-by: Tyler Michael Smith <[email protected]>

* Update

Signed-off-by: Tyler Michael Smith <[email protected]>

* Fixes - lm_eval gsm8k has correctness

Signed-off-by: Tyler Michael Smith <[email protected]>

* "just delete the assert"

Signed-off-by: Tyler Michael Smith <[email protected]>

* fixup precommit issues

Signed-off-by: Tyler Michael Smith <[email protected]>

* Fixes

Signed-off-by: Tyler Michael Smith <[email protected]>

* updated (#12)

Signed-off-by: [email protected] <[email protected]>

* Add Accuracy Test (#13)

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

---------

Signed-off-by: [email protected] <[email protected]>

* Preemption Bugfixes (#15)

* stash fixed double free issue

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* fixed issue

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updatrd

Signed-off-by: [email protected] <[email protected]>

* updatrd

Signed-off-by: [email protected] <[email protected]>

* updatrd

Signed-off-by: [email protected] <[email protected]>

* updatrd

Signed-off-by: [email protected] <[email protected]>

* updatrd

Signed-off-by: [email protected] <[email protected]>

* updatrd

Signed-off-by: [email protected] <[email protected]>

---------

Signed-off-by: [email protected] <[email protected]>

* updated (#16)

Signed-off-by: [email protected] <[email protected]>

* Fix Bad Merge | Fix Memory Leak in Upstream (#18)

* updated

Signed-off-by: [email protected] <[email protected]>

* fix merge

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

---------

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* cleanup code

Signed-off-by: [email protected] <[email protected]>

* cleanup code

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* stash

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updatted

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* revert

Signed-off-by: [email protected] <[email protected]>

* more spurious changes

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* Update vllm/distributed/kv_transfer/kv_connector/v1/nixl_connector.py

Co-authored-by: Tyler Michael Smith <[email protected]>

* Update vllm/distributed/kv_transfer/kv_connector/v1/nixl_connector.py

Co-authored-by: Tyler Michael Smith <[email protected]>

---------

Signed-off-by: ApostaC <[email protected]>
Signed-off-by: Tyler Michael Smith <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: Robert Shaw <[email protected]>
Co-authored-by: ApostaC <[email protected]>
Co-authored-by: Tyler Michael Smith <[email protected]>
Co-authored-by: Tyler Michael Smith <[email protected]>
Co-authored-by: Robert Shaw <[email protected]>
robertgshaw2-redhat added a commit that referenced this pull request May 5, 2025
* [Update] LMcache connector v1 implementation

Signed-off-by: ApostaC <[email protected]>

* [Add] examples for disaggregated prefill

Signed-off-by: ApostaC <[email protected]>

* [add] extra information about evns

Signed-off-by: ApostaC <[email protected]>

* Initial stubs for P/D scheduling changes

Signed-off-by: Tyler Michael Smith <[email protected]>

* Updates

Signed-off-by: Tyler Michael Smith <[email protected]>

* Rs branch (#3)

* updated

Signed-off-by: [email protected] <[email protected]>

* Rs branch (#5)

Signed-off-by: [email protected] <[email protected]>

* Remove Unneeded Arguments (#7)

* updated

Signed-off-by: [email protected] <[email protected]>

* stash

Signed-off-by: [email protected] <[email protected]>

* cleanup

Signed-off-by: [email protected] <[email protected]>

---------

Signed-off-by: [email protected] <[email protected]>

* Improve disagg-example.sh (#8)

- fix spelling
- CUDA_VISIBLE_DEVICES should be set externally

Signed-off-by: Tyler Michael Smith <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* added connector

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* update

Signed-off-by: [email protected] <[email protected]>

* remove

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* seems to load properly

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* Revert "updated"

This reverts commit 97316d9.

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* stash

Signed-off-by: [email protected] <[email protected]>

* added

Signed-off-by: [email protected] <[email protected]>

* diffs for local dev on macos

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* update

Signed-off-by: Robert Shaw <[email protected]>

* updaed

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* Checkpoint.

Signed-off-by: Tyler Michael Smith <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* Cleanup

Signed-off-by: Tyler Michael Smith <[email protected]>

* WIP

Signed-off-by: Tyler Michael Smith <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* updated on scheduler side

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* Hacking away

Signed-off-by: Tyler Michael Smith <[email protected]>

* cleanup

Signed-off-by: Robert Shaw <[email protected]>

* ensure request removed from running list

Signed-off-by: Robert Shaw <[email protected]>

* Runs E2E. Garbage output. Crashes on 2nd request

Signed-off-by: Tyler Michael Smith <[email protected]>

* update

Signed-off-by: Tyler Michael Smith <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* rename files

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* updated

Signed-off-by: Robert Shaw <[email protected]>

* update

Signed-off-by: Robert Shaw <[email protected]>

* Second request no longer crashes

Signed-off-by: Tyler Michael Smith <[email protected]>

* Remove gpu_model_runner hacks

Signed-off-by: Tyler Michael Smith <[email protected]>

* Clean up Justfile

Signed-off-by: Tyler Michael Smith <[email protected]>

* [Bugfix] Stale finished requests in EMPTY_MODEL_RUNNER_OUTPUT

Signed-off-by: Tyler Michael Smith <[email protected]>

* update

Signed-off-by: Tyler Michael Smith <[email protected]>

* justfile edits

Signed-off-by: Tyler Michael Smith <[email protected]>

* Update

Signed-off-by: Tyler Michael Smith <[email protected]>

* Fixes - lm_eval gsm8k has correctness

Signed-off-by: Tyler Michael Smith <[email protected]>

* "just delete the assert"

Signed-off-by: Tyler Michael Smith <[email protected]>

* fixup precommit issues

Signed-off-by: Tyler Michael Smith <[email protected]>

* Fixes

Signed-off-by: Tyler Michael Smith <[email protected]>

* updated (#12)

Signed-off-by: [email protected] <[email protected]>

* Add Accuracy Test (#13)

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

---------

Signed-off-by: [email protected] <[email protected]>

* Preemption Bugfixes (#15)

* stash fixed double free issue

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* fixed issue

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updatrd

Signed-off-by: [email protected] <[email protected]>

* updatrd

Signed-off-by: [email protected] <[email protected]>

* updatrd

Signed-off-by: [email protected] <[email protected]>

* updatrd

Signed-off-by: [email protected] <[email protected]>

* updatrd

Signed-off-by: [email protected] <[email protected]>

* updatrd

Signed-off-by: [email protected] <[email protected]>

---------

Signed-off-by: [email protected] <[email protected]>

* updated (#16)

Signed-off-by: [email protected] <[email protected]>

* Fix Bad Merge | Fix Memory Leak in Upstream (#18)

* updated

Signed-off-by: [email protected] <[email protected]>

* fix merge

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

---------

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* cleanup code

Signed-off-by: [email protected] <[email protected]>

* cleanup code

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* stash

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updatted

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* revert

Signed-off-by: [email protected] <[email protected]>

* more spurious changes

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* updated

Signed-off-by: [email protected] <[email protected]>

* Support MLA in NIXL connector

Signed-off-by: Tyler Michael Smith <[email protected]>

* WIP adding tests

Signed-off-by: Tyler Michael Smith <[email protected]>

* wip

Signed-off-by: Tyler Michael Smith <[email protected]>

* Fixes

Signed-off-by: Tyler Michael Smith <[email protected]>

---------

Signed-off-by: ApostaC <[email protected]>
Signed-off-by: Tyler Michael Smith <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: Robert Shaw <[email protected]>
Co-authored-by: ApostaC <[email protected]>
Co-authored-by: Robert Shaw <[email protected]>
Co-authored-by: [email protected] <[email protected]>
Co-authored-by: Robert Shaw <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant