feat: allow disabling trace logging, while keeping Datadog tracing enabled #346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skn0tt
changed the title
github-actions
bot
added
the
type: feature
Skn0tt
changed the title
Skn0tt
added
type: feature
mraerino
reviewed
Aug 10, 2022
Contributor
mraerino
left a comment
mraerino
left a comment
There was a problem hiding this comment.
tracing.TrackRequest is a public api so this is a breaking change?
also: we're moving to https://github.com/netlify/go-observability and other libs for our services to break up the commons lib. maybe you want to take this opportunity to move ingesteer over and make the change there instead?
Contributor
Author
|
technically, it's public, in reality, it's used by nobody: https://cs.github.com/?q=owner%3Anetlify+TrackRequest&p=1&pt=3ef9cebfa2b06556f3d994c753e4f3781cc51ab41b7f91c3ee5be7937f355c30f345ec0f2cd12b90e3716c62eaca4e8341f081aecdd4f5b12163a2b19960f7ef20c448ebad0656537f074aca7c3fc2969f0f82ccc5eba852169382d7&scope=&scopeName=All+repos happy to move to go-observability though, sounds good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the
DisableTracingconfig property added in #338 to add a more fine-granularDisableTraceLoggingoption.This allows services like Ingesteer, which have lots of requests but don't really need all of them logged, to only enable Datadog tracing, but not log information about every single request to Humio.
Works towards https://github.com/netlify/ingesteer/issues/169.