Skip to content

fix: add json annotations for ntoml.Plugin #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2022
Merged

fix: add json annotations for ntoml.Plugin #353

merged 1 commit into from
Oct 10, 2022

Conversation

@4xposed
Copy link
Contributor

@4xposed 4xposed commented Oct 7, 2022

There's still one place in buildbot where the ntoml.Plugin is serialized to json:

https://github.com/netlify/buildbot/blob/main/messages/cmd_data.go#L41

@4xposed 4xposed requested a review from a team as a code owner October 7, 2022 14:06
@4xposed 4xposed requested a review from kitop October 7, 2022 14:07
@kitop kitop requested a review from jobala October 7, 2022 14:44
jobala
jobala approved these changes Oct 10, 2022
View reviewed changes
Copy link

@jobala jobala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@4xposed 4xposed merged commit bc1ebfd into main Oct 10, 2022
@4xposed 4xposed deleted the fix_ntom_pluing-to-use-json-annotations branch October 10, 2022 08:40
@token-generator-app token-generator-app bot mentioned this pull request Oct 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kitop kitop Awaiting requested review from kitop

1 more reviewer

@jobala jobala jobala approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@4xposed @jobala