feat: make Router.enableTracing configurable #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skn0tt
added
the
type: feature
rybit
reviewed
Jun 21, 2022
server/server.go
Outdated
| } | ||
|
|
||
| type RouterConfig struct { | ||
| EnableTracing bool |
Member
There was a problem hiding this comment.
So I think that this would be oddly breaking in a functional way (the code would work). Updating here would disable this by default. I think that we should consider flipping the boolean here (e.g. DisableTracing).
rybit
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
config.Router.EnableTracingfield that makesRouter.enableTracingconfigurable.Works towards https://github.com/netlify/ingesteer/issues/152.
There are no breaking changes introduced in this.