Bugfix/231 update templates for netbox v4 1 #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrects inconsistent indentation in an access list (ACL) templates for better readability and maintainability. This change ensures a consistent format across all relevant template files.
Replace `<h5>` and `<h4>` elements with `<h2>` for better semantic structure.
Refactors the HTML templates for access control lists (ACLs) to remove unnecessary `<div>` wrappers within card components.
Eliminates unnecessary captions from tables in ACL-related templates. These captions were duplicate content and provided no additional value to the user interface.
Removed unnecessary "btn-sm" classes and replaced span icons with <i> tags for uniform styling.
Updated forms to enhance layout and spacing consistency by leveraging NetBox style classes.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
Author
|
Hey @cruse1977, I've just merged the latest changes form the |
Member
|
Hi @pheus will do, ideally want issue 233 resolved first (ie: making sure 1.8.1 is a good build on PyPi) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related Issue
[Bug] Fix Templates for NetBox v4.1 UI Update #231
New Behavior
This PR updates the plugin’s templates to align with the NetBox v4.1 UI.
Contrast to Current Behavior
The updated templates match the layout of NetBox v4.1 and later, improving consistency with the latest UI changes.
Discussion: Benefits and Drawbacks
This change ensures a consistent look and feel for the plugin when used with NetBox v4.1 and later.
It removes outdated styling, making the UI more cohesive with NetBox’s recent updates.
Changes to the Documentation
No documentation updates are required.
Proposed Release Note Entry
Updated templates to match NetBox v4.1+ UI changes.
Double Check
or in a linked issue.
devbranch.