Skip to content
This repository was archived by the owner on Feb 28, 2024. It is now read-only.

Conversation

@zkxs
Copy link
Collaborator

@zkxs zkxs commented Jul 9, 2022

  1. PostX does nothing beneficial to NML, and is not needed
  2. PostX changes NML's hash, which could be potentially problematic
    • If we ever sign the DLL
    • If the mod manager verifies files
  3. PostX changes NML's AssemblyVersionAttribute, which can lead to extremely confusing logs

Specifically, logs like this are confusing because there is no such thing as NML version 2022.4.24.539

Loader Exception: Could not load file or assembly 'NeosModLoader, Version=2022.4.24.539, Culture=neutral, PublicKeyToken=null' or one of its dependencies. The system cannot find the file specified.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants