Make the version string debug log actually work

Author: zkxs

NeosModLoader/NeosVersionReset.cs

@@ -23,6 +23,9 @@ internal static void Initialize()
             ModLoaderConfiguration config = ModLoaderConfiguration.Get();
             Engine engine = Engine.Current;
 
+            // get the version string before we mess with it
+            string originalVersionString = engine.VersionString;
+
             List<string> extraAssemblies = Engine.ExtraAssemblies;
             string assemblyFilename = Path.GetFileName(Assembly.GetExecutingAssembly().Location);
             bool nmlPresent = extraAssemblies.Remove(assemblyFilename);
@@ -118,7 +121,7 @@ internal static void Initialize()
 
             // we intentionally attempt to set the version string first, so if it fails the compatibilty hash is left on the original value
             // this is to prevent the case where a player simply doesn't know their version string is wrong
-            if (!SpoofVersionString(engine))
+            if (!SpoofVersionString(engine, originalVersionString))
             {
                 Logger.WarnInternal("Version string spoofing failed");
                 return;
@@ -215,10 +218,8 @@ private static bool SetCompatibilityHash(Engine engine, string Target)
             }
         }
 
-        private static bool SpoofVersionString(Engine engine)
+        private static bool SpoofVersionString(Engine engine, string originalVersionString)
         {
-            string cachedVersion = engine.VersionString;
-
             FieldInfo field = AccessTools.DeclaredField(engine.GetType(), "_versionString");
             if (field == null)
             {
@@ -228,7 +229,7 @@ private static bool SpoofVersionString(Engine engine)
             // null the cached value
             field.SetValue(engine, null);
 
-            Logger.DebugFuncInternal(() => $"Changing version string from {cachedVersion} to {engine.VersionString}");
+            Logger.DebugFuncInternal(() => $"Changing version string from {originalVersionString} to {engine.VersionString}");
             return true;
         }