testkit: Update NodeJS version in the Dockerfile #680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbiville
reviewed
Feb 12, 2021
The support for the `NodeJS 8.x` was dropped and the `npm update` was failing because of that. The NodeJS updagrade is being done to `10.x` since it's the oldest version in maintenance. This update was done by updating the Ubuntu version since the other of updates was broken the TLS configuration. Along with this, the TLS 1.0 was enable in the OpenSSL config since it's disable by default in this ubuntu's version.
bigmontz
force-pushed
the
4.3-testkit-update-node-version
branch
5 times, most recently
from
0d3d7f0 to
2922234
Compare
bigmontz
force-pushed
the
4.3-testkit-update-node-version
branch
from
7be60d6 to
76c866a
Compare
bigmontz
force-pushed
the
4.3-testkit-update-node-version
branch
4 times, most recently
from
ca1cc8f to
01ff9b3
Compare
bigmontz
force-pushed
the
4.3-testkit-update-node-version
branch
from
01ff9b3 to
82e9d52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The support for the
NodeJS 8.xwas dropped and thenpm updatewas failing because of that.The NodeJS upgrade is being done to
10.xsince it's the oldest version in maintenance.This update was done by updating the Ubuntu version since the other of updates was broken the TLS configuration. Along with this, the TLS 1.0 was enable in the OpenSSL config since it is disabled by default in this ubuntu's version.