Adding missing profile statistics

Author: Zhen Li

src/result-summary.js

@@ -174,12 +174,24 @@ class ProfiledPlan {
     this.operatorType = profile.operatorType
     this.identifiers = profile.identifiers
     this.arguments = profile.args
-    this.dbHits = intValue(profile.args.DbHits)
-    this.rows = intValue(profile.args.Rows)
+    this.dbHits = valueOrDefault('dbHits', profile)
+    this.rows = valueOrDefault('rows', profile)
+    this.pageCacheMisses = valueOrDefault('pageCacheMisses', profile)
+    this.pageCacheHits = valueOrDefault('pageCacheHits', profile)
+    this.pageCacheHitRatio = valueOrDefault('pageCacheHitRatio', profile)
+    this.time = valueOrDefault('time', profile)
     this.children = profile.children
       ? profile.children.map(child => new ProfiledPlan(child))
       : []
   }
+
+  hasPageCacheStats () {
+    return (
+      this.pageCacheMisses > 0 ||
+      this.pageCacheHits > 0 ||
+      this.pageCacheHitRatio > 0
+    )
+  }
 }
 
 /**
@@ -308,6 +320,15 @@ function intValue (value) {
   return isInt(value) ? value.toInt() : value
 }
 
+function valueOrDefault (key, values, defaultValue = 0) {
+  if (key in values) {
+    const value = values[key]
+    return isInt(value) ? value.toInt() : value
+  } else {
+    return defaultValue
+  }
+}
+
 const statementType = {
   READ_ONLY: 'r',
   READ_WRITE: 'rw',

test/session.test.js

@@ -25,7 +25,6 @@ import SingleConnectionProvider from '../src/internal/connection-provider-single
 import FakeConnection from './internal/fake-connection'
 import sharedNeo4j from './internal/shared-neo4j'
 import _ from 'lodash'
-import { ServerVersion, VERSION_4_0_0 } from '../src/internal/server-version'
 import { isString } from '../src/internal/util'
 import testUtils from './internal/test-utils'
 import { newError, PROTOCOL_ERROR, SESSION_EXPIRED } from '../src/error'
@@ -299,7 +298,6 @@ describe('#integration session', () => {
       expect(sum.profile.identifiers[0]).toBe('n')
       expect(sum.profile.children[0].operatorType).toBeDefined()
       expect(sum.profile.rows).toBe(0)
-      // expect(sum.profile.dbHits).toBeGreaterThan(0);
       done()
     })
   })

test/summary.test.js

@@ -153,6 +153,8 @@ describe('#integration result summary', () => {
 
       expect(profile.dbHits).toBe(0)
       expect(profile.rows).toBe(1)
+      expect(profile.time).toBe(0)
+      expect(profile.hasPageCacheStats()).toBe(false)
 
       done()
     })

test/types/result-summary.test.ts

@@ -56,6 +56,11 @@ const profileIdentifiers: string[] = profile.identifiers
 const profileArguments: { [key: string]: string } = profile.arguments
 const profileDbHits: number = profile.dbHits
 const profileRows: number = profile.rows
+const hasPageCacheStats: boolean = profile.hasPageCacheStats()
+const profilePageCacheMisses: number = profile.pageCacheMisses
+const profilePageCacheHits: number = profile.pageCacheHits
+const profilePageCacheHitRatio: number = profile.pageCacheHitRatio
+const time: number = profile.time
 const profileChildren: ProfiledPlan[] = profile.children
 
 const notifications: Notification[] = sum1.notifications

types/result-summary.d.ts

@@ -49,6 +49,13 @@ declare interface ProfiledPlan {
   arguments: { [key: string]: string }
   dbHits: number
   rows: number
+  pageCacheMisses: number
+  pageCacheHits: number
+  pageCacheHitRatio: number
+  time: number
+
+  hasPageCacheStats(): boolean
+
   children: ProfiledPlan[]
 }