remove the chunk creation from the connection

Author: bigmontz

src/internal/connection-channel.js

@@ -71,37 +71,46 @@ export function createChannelConnection (
   const channel = new Channel(channelConfig)
 
   return Bolt.handshake(channel)
-    .then(({ protocolVersion, consumeRemainingBuffer }) => {
+    .then(({ protocolVersion: version, consumeRemainingBuffer }) => {
+      const chunker = new Chunker(channel)
+      const dechunker = new Dechunker()
+
       const connection = new ChannelConnection(
         channel,
         errorHandler,
         address,
         log,
         config.disableLosslessIntegers,
-        serversideRouting
+        serversideRouting,
+        {
+          newChunker: () => chunker,
+          newDechunker: () => dechunker
+        }
       )
 
-      connection._protocol = Bolt.create({
-        version: protocolVersion,
+      const protocol = Bolt.create({
+        version,
         connection,
-        chunker: connection._chunker,
+        chunker,
         disableLosslessIntegers: config.disableLosslessIntegers,
         serversideRouting
       })
 
+      connection._protocol = protocol
+
       // reset the error handler to just handle errors and forget about the handshake promise
       channel.onerror = connection._handleFatalError.bind(connection)
 
       // Ok, protocol running. Simply forward all messages to the dechunker
-      channel.onmessage = buf => connection._dechunker.write(buf)
+      channel.onmessage = buf => dechunker.write(buf)
 
       // setup dechunker to dechunk messages and forward them to the message handler
-      connection._dechunker.onmessage = buf => {
-        connection._handleMessage(connection._protocol.unpacker().unpack(buf))
+      dechunker.onmessage = buf => {
+        connection._handleMessage(protocol.unpacker().unpack(buf))
       }
 
       // forward all pending bytes to the dechunker
-      consumeRemainingBuffer(buffer => connection._dechunker.write(buffer))
+      consumeRemainingBuffer(buffer => dechunker.write(buffer))
 
       return connection
     })
@@ -127,7 +136,11 @@ export default class ChannelConnection extends Connection {
     address,
     log,
     disableLosslessIntegers = false,
-    serversideRouting = null
+    serversideRouting = null,
+    {
+      newChunker = channel => new Chunker(channel),
+      newDechunker = () => new Dechunker()
+    } = {}
   ) {
     super(errorHandler)
 
@@ -139,8 +152,8 @@ export default class ChannelConnection extends Connection {
     this._pendingObservers = []
     this._currentObserver = undefined
     this._ch = channel
-    this._dechunker = new Dechunker()
-    this._chunker = new Chunker(channel)
+    this._dechunker = newDechunker()
+    this._chunker = newChunker(channel)
     this._log = log
     this._serversideRouting = serversideRouting