Fixes after code review for examples test

 * use constants for user and password
 * test custom auth with basic auth params

Author: lutovich

test/v1/examples.test.js

@@ -34,6 +34,9 @@ describe('examples', () => {
   let testResultPromise;
   let resolveTestResultPromise;
 
+  const user = 'neo4j';
+  const password = 'neo4j';
+
   beforeAll(() => {
     originalTimeout = jasmine.DEFAULT_TIMEOUT_INTERVAL;
     jasmine.DEFAULT_TIMEOUT_INTERVAL = 10000;
@@ -89,9 +92,6 @@ describe('examples', () => {
   });
 
   it('basic auth example', done => {
-    const user = 'neo4j';
-    const password = 'neo4j';
-
     // tag::basic-auth[]
     const driver = neo4j.driver('bolt://localhost:7687', neo4j.auth.basic(user, password));
     // end::basic-auth[]
@@ -107,9 +107,6 @@ describe('examples', () => {
   });
 
   it('config max retry time example', done => {
-    const user = 'neo4j';
-    const password = 'neo4j';
-
     // tag::config-max-retry-time[]
     const maxRetryTimeMs = 15 * 1000; // 15 seconds
     const driver = neo4j.driver('bolt://localhost:7687', neo4j.auth.basic(user, password),
@@ -130,9 +127,6 @@ describe('examples', () => {
   });
 
   it('config trust example', done => {
-    const user = 'neo4j';
-    const password = 'neo4j';
-
     // tag::config-trust[]
     const driver = neo4j.driver('bolt://localhost:7687', neo4j.auth.basic(user, password),
       {
@@ -158,9 +152,6 @@ describe('examples', () => {
   });
 
   it('config unencrypted example', done => {
-    const user = 'neo4j';
-    const password = 'neo4j';
-
     // tag::config-unencrypted[]
     const driver = neo4j.driver('bolt://localhost:7687', neo4j.auth.basic(user, password),
       {
@@ -179,11 +170,11 @@ describe('examples', () => {
     });
   });
 
-  it('custom auth example', () => {
-    const principal = 'principal';
-    const credentials = 'credentials';
-    const realm = 'realm';
-    const scheme = 'scheme';
+  it('custom auth example', done => {
+    const principal = user;
+    const credentials = password;
+    const realm = undefined;
+    const scheme = 'basic';
     const parameters = {};
 
     // tag::custom-auth[]
@@ -193,7 +184,14 @@ describe('examples', () => {
     );
     // end::custom-auth[]
 
-    expect(driver).toBeDefined();
+    driver.onCompleted = () => {
+      done();
+    };
+
+    const session = driver.session();
+    session.run('RETURN 1').then(() => {
+      session.close();
+    });
   });
 
   it('cypher error example', done => {
@@ -221,9 +219,6 @@ describe('examples', () => {
   });
 
   it('driver lifecycle example', done => {
-    const user = 'neo4j';
-    const password = 'neo4j';
-
     // tag::driver-lifecycle[]
     const driver = neo4j.driver('bolt://localhost:7687', neo4j.auth.basic(user, password));
 
@@ -251,9 +246,6 @@ describe('examples', () => {
   });
 
   it('hello world example', done => {
-    const user = 'neo4j';
-    const password = 'neo4j';
-
     // tag::hello-world[]
     const driver = neo4j.driver('bolt://localhost:7687', neo4j.auth.basic(user, password));
     const session = driver.session();
@@ -395,7 +387,6 @@ describe('examples', () => {
   });
 
   it('service unavailable example', done => {
-    const user = 'neo4j';
     const password = 'wrongPassword';
 
     // tag::service-unavailable[]