Skip to content

Use OPT_EAGER_TX_BEGIN for assert behaviour in Disconnects and Authorization tests #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bigmontz merged 1 commit into from
Feb 10, 2022
Merged

Use OPT_EAGER_TX_BEGIN for assert behaviour in Disconnects and Authorization tests #397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions tests/stub/authorization/test_authorization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,8 +193,7 @@ def _fail_on_begin_using_tx_run(self, error, error_assertion):

session = driver.session("r", database=self.get_db())

# TODO: remove block when all drivers behave the same way
if get_driver_name() in ["javascript", "go"]:
if not self.driver_supports_features(types.Feature.OPT_EAGER_TX_BEGIN):
tx = session.begin_transaction()
with self.assertRaises(types.DriverError) as exc:
tx.run("cypher").next()
Expand Down
9 changes: 5 additions & 4 deletions tests/stub/disconnects/test_disconnects.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,10 +177,11 @@ def test_disconnect_on_tx_begin(self):
self._server.done()

expected_step = "after begin"
if self._driver_name in ["go"]:
expected_step = "after run"
elif self._driver_name in ["javascript"]:
expected_step = "after first next"
if not self.driver_supports_features(types.Feature.OPT_EAGER_TX_BEGIN):
if self._driver_name in ["go"]:
expected_step = "after run"
elif self._driver_name in ["javascript"]:
expected_step = "after first next"
self.assertEqual(step, expected_step)

def test_disconnect_on_tx_run(self):
Expand Down