From 126978238e0b1984e0ab6dadf5015524b400159c Mon Sep 17 00:00:00 2001
From: Rouven Bauer <rouven.bauer@neo4j.com>
Date: Thu, 7 Oct 2021 15:27:42 +0200
Subject: [PATCH] Add tests for summary fields `contains-system-updates` and
 `contains-updates`

---
 ...ial_summary_contains_system_updates.script | 11 +++++++
 .../partial_summary_contains_updates.script   | 11 +++++++
 ...summary_not_contains_system_updates.script | 11 +++++++
 ...artial_summary_not_contains_updates.script | 11 +++++++
 tests/stub/summary/test_summary.py            | 30 +++++++++++++++++++
 5 files changed, 74 insertions(+)
 create mode 100644 tests/stub/summary/scripts/partial_summary_contains_system_updates.script
 create mode 100644 tests/stub/summary/scripts/partial_summary_contains_updates.script
 create mode 100644 tests/stub/summary/scripts/partial_summary_not_contains_system_updates.script
 create mode 100644 tests/stub/summary/scripts/partial_summary_not_contains_updates.script

diff --git a/tests/stub/summary/scripts/partial_summary_contains_system_updates.script b/tests/stub/summary/scripts/partial_summary_contains_system_updates.script
new file mode 100644
index 000000000..adf68c04a
--- /dev/null
+++ b/tests/stub/summary/scripts/partial_summary_contains_system_updates.script
@@ -0,0 +1,11 @@
+!: BOLT 4.4
+
+A: HELLO {"{}": "*"}
+*: RESET
+C: RUN "*" "*" "*"
+S: SUCCESS {"t_first": 2001, "fields": ["n"]}
+C: PULL {"n": "*"}
+S: RECORD [1]
+   SUCCESS {"type": "r", "db": "apple", "t_last": 2002, "stats": {"contains-system-updates": true}}
+*: RESET
+?: GOODBYE
diff --git a/tests/stub/summary/scripts/partial_summary_contains_updates.script b/tests/stub/summary/scripts/partial_summary_contains_updates.script
new file mode 100644
index 000000000..12eb27451
--- /dev/null
+++ b/tests/stub/summary/scripts/partial_summary_contains_updates.script
@@ -0,0 +1,11 @@
+!: BOLT 4.4
+
+A: HELLO {"{}": "*"}
+*: RESET
+C: RUN "*" "*" "*"
+S: SUCCESS {"t_first": 2001, "fields": ["n"]}
+C: PULL {"n": "*"}
+S: RECORD [1]
+   SUCCESS {"type": "r", "db": "apple", "t_last": 2002, "stats": {"contains-updates": true}}
+*: RESET
+?: GOODBYE
diff --git a/tests/stub/summary/scripts/partial_summary_not_contains_system_updates.script b/tests/stub/summary/scripts/partial_summary_not_contains_system_updates.script
new file mode 100644
index 000000000..61f1b904d
--- /dev/null
+++ b/tests/stub/summary/scripts/partial_summary_not_contains_system_updates.script
@@ -0,0 +1,11 @@
+!: BOLT 4.4
+
+A: HELLO {"{}": "*"}
+*: RESET
+C: RUN "*" "*" "*"
+S: SUCCESS {"t_first": 2001, "fields": ["n"]}
+C: PULL {"n": "*"}
+S: RECORD [1]
+   SUCCESS {"type": "r", "db": "apple", "t_last": 2002, "stats": {"system-updates": 1234, "contains-system-updates": false}}
+*: RESET
+?: GOODBYE
diff --git a/tests/stub/summary/scripts/partial_summary_not_contains_updates.script b/tests/stub/summary/scripts/partial_summary_not_contains_updates.script
new file mode 100644
index 000000000..b3ef0bbfe
--- /dev/null
+++ b/tests/stub/summary/scripts/partial_summary_not_contains_updates.script
@@ -0,0 +1,11 @@
+!: BOLT 4.4
+
+A: HELLO {"{}": "*"}
+*: RESET
+C: RUN "*" "*" "*"
+S: SUCCESS {"t_first": 2001, "fields": ["n"]}
+C: PULL {"n": "*"}
+S: RECORD [1]
+   SUCCESS {"type": "r", "db": "apple", "t_last": 2002, "stats": {"constraints-added": 1234, "contains-updates": false}}
+*: RESET
+?: GOODBYE
diff --git a/tests/stub/summary/test_summary.py b/tests/stub/summary/test_summary.py
index 9aeadb5b4..4bbcd02f4 100644
--- a/tests/stub/summary/test_summary.py
+++ b/tests/stub/summary/test_summary.py
@@ -302,6 +302,36 @@ def test_partial_summary_constraints_removed(self):
             summary, constraints_removed=1234, contains_updates=True
         )
 
+    @driver_feature(types.Feature.TMP_FULL_SUMMARY)
+    def test_partial_summary_contains_system_updates(self):
+        summary = self._get_summary(
+            "partial_summary_contains_system_updates.script"
+        )
+        self._assert_counters(summary, contains_system_updates=True)
+
+    @driver_feature(types.Feature.TMP_FULL_SUMMARY)
+    def test_partial_summary_contains_updates(self):
+        summary = self._get_summary("partial_summary_contains_updates.script")
+        self._assert_counters(summary, contains_updates=True)
+
+    @driver_feature(types.Feature.TMP_FULL_SUMMARY)
+    def test_partial_summary_not_contains_system_updates(self):
+        summary = self._get_summary(
+            "partial_summary_not_contains_system_updates.script"
+        )
+        self._assert_counters(
+            summary, system_updates=1234, contains_system_updates=False
+        )
+
+    @driver_feature(types.Feature.TMP_FULL_SUMMARY)
+    def test_partial_summary_not_contains_updates(self):
+        summary = self._get_summary(
+            "partial_summary_not_contains_updates.script"
+        )
+        self._assert_counters(
+            summary, constraints_added=1234, contains_updates=False
+        )
+
     @driver_feature(types.Feature.TMP_FULL_SUMMARY)
     def test_partial_summary_indexes_added(self):
         summary = self._get_summary("partial_summary_indexes_added.script")