Skip to content

Commit 7ceaa4d

Browse files
committed
Use OPT_EAGER_TX_BEGIN for assert behaviour in Disconnects and Authorization tests
1 parent 22cce55 commit 7ceaa4d

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

tests/stub/authorization/test_authorization.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -193,8 +193,7 @@ def _fail_on_begin_using_tx_run(self, error, error_assertion):
193193

194194
session = driver.session("r", database=self.get_db())
195195

196-
# TODO: remove block when all drivers behave the same way
197-
if get_driver_name() in ["javascript", "go"]:
196+
if not self.driver_supports_features(types.Feature.OPT_EAGER_TX_BEGIN):
198197
tx = session.begin_transaction()
199198
with self.assertRaises(types.DriverError) as exc:
200199
tx.run("cypher").next()

tests/stub/disconnects/test_disconnects.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -177,10 +177,11 @@ def test_disconnect_on_tx_begin(self):
177177
self._server.done()
178178

179179
expected_step = "after begin"
180-
if self._driver_name in ["go"]:
181-
expected_step = "after run"
182-
elif self._driver_name in ["javascript"]:
183-
expected_step = "after first next"
180+
if not self.driver_supports_features(types.Feature.OPT_EAGER_TX_BEGIN):
181+
if self._driver_name in ["go"]:
182+
expected_step = "after run"
183+
elif self._driver_name in ["javascript"]:
184+
expected_step = "after first next"
184185
self.assertEqual(step, expected_step)
185186

186187
def test_disconnect_on_tx_run(self):

0 commit comments

Comments
 (0)