Skip to content

Commit 16e3b2c

Browse files
committed
Take the negative instead of reciprocal.
1 parent c3dd8d9 commit 16e3b2c

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

mllib/src/main/scala/org/apache/spark/ml/evaluation/RegressionEvaluator.scala

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,13 +70,13 @@ final class RegressionEvaluator(override val uid: String)
7070
val metrics = new RegressionMetrics(predictionAndLabels)
7171
val metric = $(metricName) match {
7272
case "rmse" =>
73-
1 / metrics.rootMeanSquaredError
73+
-metrics.rootMeanSquaredError
7474
case "mse" =>
75-
1 / metrics.meanSquaredError
75+
-metrics.meanSquaredError
7676
case "r2" =>
7777
metrics.r2
7878
case "mae" =>
79-
1 / metrics.meanAbsoluteError
79+
-metrics.meanAbsoluteError
8080
}
8181
metric
8282
}

mllib/src/test/scala/org/apache/spark/ml/evaluation/RegressionEvaluatorSuite.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,14 +58,14 @@ class RegressionEvaluatorSuite extends SparkFunSuite with MLlibTestSparkContext
5858

5959
// default = rmse
6060
val evaluator = new RegressionEvaluator()
61-
assert(evaluator.evaluate(predictions) ~== 0.1019382 absTol 0.001)
61+
assert(evaluator.evaluate(predictions) ~== -0.1019382 absTol 0.001)
6262

6363
// r2 score
6464
evaluator.setMetricName("r2")
6565
assert(evaluator.evaluate(predictions) ~== 0.9998196 absTol 0.001)
6666

6767
// mae
6868
evaluator.setMetricName("mae")
69-
assert(evaluator.evaluate(predictions) ~== 0.08036075 absTol 0.001)
69+
assert(evaluator.evaluate(predictions) ~== -0.08036075 absTol 0.001)
7070
}
7171
}

0 commit comments

Comments
 (0)