Skip to content

Commit 9e6627e

Browse files
committed
HBASE-24007 Get -PrunLargeTests passing on JDK11 (apache#1351)
Minor tweaks required to get passing runs of `-PrunLargeTests`. * Minimum Hadoop version is 3.2.0 due to [HADOOP-12760](https://issues.apache.org/jira/browse/HADOOP-12760). * JDK11 looks like it consumes more memory than JDK8, so failures due to OOME see more common here. Bumping heap allocated to surefire forks allows better pass rate. Signed-off-by: Jan Hentschel <[email protected]>
1 parent c06af5d commit 9e6627e

File tree

1 file changed

+13
-1
lines changed

1 file changed

+13
-1
lines changed

pom.xml

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1422,7 +1422,10 @@
14221422
<test.output.tofile>true</test.output.tofile>
14231423
<surefire.timeout>900</surefire.timeout>
14241424
<test.exclude.pattern></test.exclude.pattern>
1425-
<!-- default Xmx value is 2800m. Use -Dsurefire.Xmx=xxg to run tests with different JVM Xmx value -->
1425+
<!--
1426+
default Xmx value is 2800m. Use -Dsurefire.Xmx=xxg to run tests with different JVM Xmx value.
1427+
this value is managed separately for jdk11.
1428+
-->
14261429
<surefire.Xmx>2800m</surefire.Xmx>
14271430
<surefire.cygwinXmx>2800m</surefire.cygwinXmx>
14281431
<!--Mark our test runs with '-Dhbase.build.id' so we can identify a surefire test as ours in a process listing
@@ -2236,6 +2239,15 @@
22362239
<properties>
22372240
<!-- TODO: replicate logic for windows support -->
22382241
<argLine>--add-opens=java.base/jdk.internal.ref=ALL-UNNAMED ${hbase-surefire.argLine}</argLine>
2242+
<!-- We need a minimum HDFS version of 3.2.0 for HADOOP-12760 -->
2243+
<hadoop-three.version>3.2.0</hadoop-three.version>
2244+
<!--
2245+
JDK11 appears to consume more heap than JDK8 does; OOME are more common in
2246+
-PrunLargeTests on this platform. Bump up heap allocated to tests (current default for
2247+
JDK8 is 2800m.
2248+
TODO: replicate logic for windows
2249+
-->
2250+
<surefire.Xmx>3200m</surefire.Xmx>
22392251
</properties>
22402252
<build>
22412253
<plugins>

0 commit comments

Comments
 (0)