Add close button for android #204
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you also add Caption + Logo(image) in this overlay at Top(left side) with Close Button at Right side? |
Saqib92
reviewed
Nov 13, 2019
Saqib92
left a comment
Saqib92
left a comment
There was a problem hiding this comment.
Working Fine Tested on Android 9 Emulator.
shamilovtim
reviewed
Nov 13, 2019
Collaborator
shamilovtim
left a comment
shamilovtim
left a comment
There was a problem hiding this comment.
Thanks for submitting this. Code looks fine. It wouldn't hurt to move it to a separate method.
Additionally, there is no working example in this repo, which makes PRs difficult to test. Before I can merge your PR I need to get a minimal working example in here.
|
Excuse me. I updated the code, but I cannot see the close button in full screen mode. T.T |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a Text button on top of view
What issue is this PR resolving? Alternatively, please describe the bugfix/enhancement this PR aims to provide
Have you provided unit tests that either prove the bugfix or cover the enhancement?
Related issues