Skip to content

Commit 1536222

Browse files
EgorPopelyaevnazar-pc
authored andcommitted
Fix publishing of thechain-spec-builder image (paritytech#5387)
This PR fixes the issue with the publishing flow of the `chain-speck-builder` image Closes: https://github.com/paritytech/release-engineering/issues/219
1 parent 639f16c commit 1536222

1 file changed

Lines changed: 17 additions & 7 deletions

File tree

.github/workflows/release-50_publish-docker.yml

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -75,12 +75,13 @@ env:
7575
# EVENT_ACTION: ${{ github.event.action }}
7676
EVENT_NAME: ${{ github.event_name }}
7777
IMAGE_TYPE: ${{ inputs.image_type }}
78-
VERSION: ${{ inputs.version }}
7978

8079
jobs:
8180
validate-inputs:
8281
runs-on: ubuntu-latest
8382
outputs:
83+
version: ${{ steps.validate_inputs.outputs.VERSION }}
84+
release_id: ${{ steps.validate_inputs.outputs.RELEASE_ID }}
8485
stable_tag: ${{ steps.validate_inputs.outputs.stable_tag }}
8586

8687
steps:
@@ -93,17 +94,20 @@ jobs:
9394
. ./.github/scripts/common/lib.sh
9495
9596
VERSION=$(filter_version_from_input "${{ inputs.version }}")
96-
echo "VERSION=${VERSION}" >> $GITHUB_ENV
97+
echo "VERSION=${VERSION}" >> $GITHUB_OUTPUT
9798
9899
RELEASE_ID=$(check_release_id "${{ inputs.release_id }}")
99-
echo "RELEASE_ID=${RELEASE_ID}" >> $GITHUB_ENV
100+
echo "RELEASE_ID=${RELEASE_ID}" >> $GITHUB_OUTPUT
101+
102+
echo "Release ID: $RELEASE_ID"
100103
101104
STABLE_TAG=$(validate_stable_tag ${{ inputs.stable_tag }})
102105
echo "stable_tag=${STABLE_TAG}" >> $GITHUB_OUTPUT
103106
104107
fetch-artifacts: # this job will be triggered for the polkadot-parachain rc and release or polkadot rc image build
105108
if: ${{ inputs.binary == 'polkadot-parachain' || inputs.binary == 'chain-spec-builder' || inputs.image_type == 'rc' }}
106109
runs-on: ubuntu-latest
110+
needs: [validate-inputs]
107111

108112
steps:
109113
- name: Checkout sources
@@ -129,6 +133,7 @@ jobs:
129133
run: |
130134
. ./.github/scripts/common/lib.sh
131135
136+
VERSION="${{ needs.validate-inputs.outputs.VERSION }}"
132137
fetch_release_artifacts_from_s3
133138
134139
- name: Fetch chain-spec-builder rc artifacts or release artifacts based on release id
@@ -137,6 +142,7 @@ jobs:
137142
run: |
138143
. ./.github/scripts/common/lib.sh
139144
145+
RELEASE_ID="${{ needs.validate-inputs.outputs.RELEASE_ID }}"
140146
fetch_release_artifacts
141147
142148
- name: Upload artifacts
@@ -181,8 +187,7 @@ jobs:
181187
run: |
182188
. ./.github/scripts/common/lib.sh
183189
184-
RELEASE_ID=$(check_release_id "${{ inputs.release_id }}")
185-
release=release-$RELEASE_ID && \
190+
release="release-${{ needs.validate-inputs.outputs.RELEASE_ID }}" && \
186191
echo "release=${release}" >> $GITHUB_OUTPUT
187192
188193
commit=$(git rev-parse --short HEAD) && \
@@ -198,9 +203,14 @@ jobs:
198203
id: fetch_release_refs
199204
run: |
200205
chmod a+rx $BINARY
201-
[[ $BINARY != 'chain-spec-builder' ]] && VERSION=$(./$BINARY --version | awk '{ print $2 }' )
202206
203-
release=$( echo $VERSION | cut -f1 -d- )
207+
if [[ $BINARY != 'chain-spec-builder' ]]; then
208+
VERSION=$(./$BINARY --version | awk '{ print $2 }' )
209+
release=$( echo $VERSION | cut -f1 -d- )
210+
else
211+
release=$(echo ${{ needs.validate-inputs.outputs.VERSION }} | sed 's/^v//')
212+
fi
213+
204214
echo "tag=latest" >> $GITHUB_OUTPUT
205215
echo "release=${release}" >> $GITHUB_OUTPUT
206216
echo "stable=${{ needs.validate-inputs.outputs.stable_tag }}" >> $GITHUB_OUTPUT

0 commit comments

Comments
 (0)