Address student feedback for How-To Framing protocol #4314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeStarch
requested changes
Oct 16, 2025
Collaborator
LeStarch
left a comment
LeStarch
left a comment
There was a problem hiding this comment.
Minor nits, but prepared to merge when addressed.
Collaborator
|
Does this address the difference between "payload" and "framing"? If not we should The structure of the payload is not determined by the framer/deframer. Only the outer-shell. Payload structure is determined by the producer/consumer of the data. |
LeStarch
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Address student feedback for #3633 : How-To Implement a Custom Framing protocol in F´
Fixes #3633
Fixes #3663
Gen AI Usage
Gave the feedback to Copilot, which suggested changes, then I reviewed and modified the proposed changes to fit.