Skip to content

Conversation

@m-aleem
Copy link
Contributor

@m-aleem m-aleem commented Jun 24, 2025

Related Issue(s) #3446
Has Unit Tests (y/n) Yes - Existing
Documentation Included (y/n) N/A

Change Description

I locally updated fprime/cmake/settings.cmake to change -DPROTECTED=protected -DPRIVATE=private. This causes additional build errors beyond all our updates in manual code for PRIVATE->private and PROTECTED->protected due to auto-coded files which use PRIVATE, PROTECTED. This set of changes is associated with fixing Svc/CmdSequencer so that the UTs in this directory can build and pass.

Approach in this case was:

  1. Add protected accessor methods for opcodes

Rationale

#3446

Future Work

  1. Note that this PR does not include the update to fprime/cmake/settings.cmake itself - this will be done at the end
  2. Note that this PR does not include re-naming the flight code Impl to (separate issue)

@m-aleem m-aleem marked this pull request as ready for review June 24, 2025 21:36
@LeStarch LeStarch merged commit 959d19d into nasa:devel Jun 25, 2025
51 checks passed
@m-aleem m-aleem deleted the devel-3446-af-v2 branch June 25, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants