-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Closed
nasa/fpp
#619Labels
Easy First IssueAn issue that should be straight forward to implement, and easily tested via CI.An issue that should be straight forward to implement, and easily tested via CI.FPPIssues related to FPPIssues related to FPPbug
Milestone
Description
| F´ Version | v3.5.0-12-gde8dd0d78 |
| Affected Component | FPP autocode |
Problem Description
When a call is made to a disconnected port, we trip an ASSERT.
void Output[...]Port ::
invoke()
{
#if FW_PORT_TRACING == 1
this->trace();
#endif
#if FW_PORT_SERIALIZATION
FW_ASSERT((this->m_port != nullptr) || (this->m_serPort != nullptr));
This assert does not include in its arguments any information about which port tripped, which can make it unnecessarily difficult to debug the error. The same applies to the equivalent assert when FW_PORT_SERIALIZATION is turned off.
Context / Environment
Execute fprime-util version-check and share the output.
Operating System: Linux
CPU Architecture: x86_64
Platform: Linux-5.15.153.1-microsoft-standard-WSL2-x86_64-with-glibc2.34
Python version: 3.9.18
CMake version: 3.26.5
Pip version: 21.2.3
Pip packages:
fprime-tools==3.5.0
fprime-gds==3.5.0
fprime-fpp-*==2.2.0
How to Reproduce
- Call a disconnected port.
- Observe the resulting assert.
Expected Behavior
Assertions that can be triggered in a variety of different code paths should include arguments that identify the circumstance in which it occurred.
Metadata
Metadata
Assignees
Labels
Easy First IssueAn issue that should be straight forward to implement, and easily tested via CI.An issue that should be straight forward to implement, and easily tested via CI.FPPIssues related to FPPIssues related to FPPbug
Type
Projects
Status
Done
Status
Done